Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pm): update all prosemirror package dependencies #4714

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented Dec 20, 2023

Please describe your changes

This PR will update all Prosemirror dependencies to their latest version.

How did you accomplish your changes

  1. Increased all prosemirror deps in the package.json of the pm package.
  2. Got rid of typings that are non matching the prosemirror's typings
  3. Added new commands that were missing before

How have you tested your changes

I ran my tests locally and it worked fine - the only test currently not working is the Link test but this is not caused by this PR and is fixed in another PR.

How can we verify your changes

Clone this PR locally, run it and test the functionality of the demo pages

Remarks

Not sure how breaking the changes are on Prosemirror's side - on our end we didn't remove or add anything significant except getting rid of non-existing objects anymore that were not there on Prosemirrors typings.

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

fixes #3826

Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 8c8f14f
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/658259798ed3280008c2e6d4
😎 Deploy Preview https://deploy-preview-4714--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch bdbch marked this pull request as ready for review January 2, 2024 11:04
@bdbch bdbch requested a review from svenadlung as a code owner January 2, 2024 11:04
@bdbch bdbch requested a review from montapro January 2, 2024 11:05
@bdbch bdbch self-assigned this Jan 2, 2024
Copy link

@montapro montapro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Google translate doesn't work with editor contents
2 participants