Bump prosemirror-view version to fix Google translation in editor #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
thefinnomenon
changed the title
|
I have a PR open that updates all Prosemirror dependencies – see #4714 |
bdbch
added
the
Info: Duplicate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Google translate doesn't work on the editor because the translate attribute is not being properly passed. This PR bumps
prosemirror-viewto the version with the fix.How did you accomplish your changes
I found the version that had the fix and updated the version in
package.jsonhttps://github.com/ProseMirror/prosemirror-view/releases/tag/1.31.2
How have you tested your changes
Manually tested in browser
Checklist
[x] The changes are not breaking the editor
[x] Added tests where possible
[x] Followed the guidelines
[x] Fixed linting issues
Related issues
Close #3826