fix for data attributes not rendering after pr #4082

[moham96]

Please describe your changes

after pr #4082 there is a regression where data attributes don't trickle down to the last render function, this fixes it

How did you accomplish your changes

I passed the html attributes to the last renderHtml by merging

How have you tested your changes

I ran the demo and verified the rendered attributes

How can we verify your changes

run the demo and inspect the mention elements, you should see data attributes render correctly

Remarks

Not sure if this is the right way to accomplish this since it is mutating the options object, the other fix would be to change the type of renderHTML to renderHTML: (props: { options: MentionOptions; node: ProseMirrorNode, HTMLAttributes?:Record<string, any>}) => DOMOutputSpec and pass the merged attributes

Checklist

• The changes are not breaking the editor
• Added tests where possible
• Followed the guidelines
• Fixed linting issues

Related issues

#4082

[netlify]

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	1ab920f
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/65f42bd1117fcd000804bbf7
😎 Deploy Preview	https://deploy-preview-4980--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[moham96]

The test failing has nothing to do with the change, it is cause by not checking for null in the images example.

[Joroze]

@bdbch can this PR get some prioritization for the Mention extension defect?

Personally not urgent but would love to update to the latest TipTap once its fixed!

Thank you

#4845

[svenadlung]

LGTM. @bdbch what do you think?

The base branch was changed.