Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min staking commission rate #1082

Closed
4 tasks
robert-zaremba opened this issue Jun 30, 2022 · 2 comments · Fixed by #1379
Closed
4 tasks

Min staking commission rate #1082

robert-zaremba opened this issue Jun 30, 2022 · 2 comments · Fixed by #1379
Assignees
@robert-zaremba @gsk967
Labels
C:Core Core app features T:Test
Milestone
v3

Comments

@robert-zaremba
Copy link
Member

robert-zaremba commented Jun 30, 2022 •
edited
Loading

Summary

With prop16 https://www.mintscan.io/umee/proposals/16 passing we need to add consensus based min delegation commission rate

Proposal

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@robert-zaremba robert-zaremba modified the milestones: v4, v3 - Calypso Jun 30, 2022
@robert-zaremba
Copy link
Member Author

We will implement it in v3 migration

@robert-zaremba robert-zaremba self-assigned this Jul 12, 2022
@robert-zaremba
Copy link
Member Author

small task ~ beginning of the next week.

@robert-zaremba robert-zaremba added T:Test C:Core Core app features labels Sep 13, 2022
@robert-zaremba robert-zaremba mentioned this issue Sep 13, 2022
Open
@gsk967 gsk967 mentioned this issue Sep 14, 2022
Merged
17 tasks
@mergify mergify bot closed this as completed in #1379 Sep 15, 2022
mergify bot pushed a commit that referenced this issue Sep 15, 2022
@gsk967
feat: add update minCommissionRate to validators (#1379)
d9c8367 
## Description
This pull request contains the update staking minimum commission rate to all the validators whose validator commission rate below the minimum commission rate 
closes: #1082 

---

### Author Checklist

_All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues._

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] added appropriate labels to the PR
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

_All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items._

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robert-zaremba robert-zaremba

@gsk967 gsk967

Labels
C:Core Core app features T:Test
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

feat: add update minCommissionRate to validators umee-network/umee
2 participants
@robert-zaremba @gsk967