-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add update minCommissionRate to validators #1379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- We also need to update params by setting a
params.MinCommissionRate
- Let's move
setMinimumCommissionRateToValidatros
to another package and test it. I suggestapp/upgrades/
- test
SetMinimumCommissionRateToValidatros
. Ideally we should test it using mocks and only the staking keeper.
Codecov Report
@@ Coverage Diff @@
## main #1379 +/- ##
==========================================
+ Coverage 52.35% 52.84% +0.49%
==========================================
Files 70 72 +2
Lines 6784 6861 +77
==========================================
+ Hits 3552 3626 +74
- Misses 2964 2966 +2
- Partials 268 269 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pre approving. Make sure that files not needed for the app have _test.go
suffix.
Also - maybe we can rename this directory to upgradesv3
? What do you think?
How about we keep all v3 upgrade handlers related files inside |
I don't like import aliases, then you need to alias all imports, which is not really good. Also, this indicates as a v3 version of |
Description
This pull request contains the update staking minimum commission rate to all the validators whose validator commission rate below the minimum commission rate
closes: #1082
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...