fix: fix the rewards collects for bid

[gsk967]

Description

closes: #XXXX

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• added appropriate labels to the PR
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

Summary by CodeRabbit

• Bug Fixes

  • Improved accuracy in bid reward calculations for auctions.
  • Enhanced logic for handling bids and rewards, including better validation and transfers.

• Refactor

  • Updated coin transfer logic in the leverage module for more precise fund handling.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates enhance the auction and leverage modules. The rewardsBid function in the auction module now includes refined bid and reward handling, ensuring accurate calculations and proper transfers. Similarly, the leverage module's fundModules function now uses a specific method for coin transfers, improving clarity and functionality.

Changes

File Path	Change Summary
x/auction/keeper/rewards.go	Updated rewardsBid function to handle bid rewards, adjust minBid calculation, refine bid and reward logic, and ensure proper module transfers.
x/leverage/keeper/oracle.go	Updated fundModules function to use SendCoinsFromModuleToAccount from bankKeeper with adjusted parameters.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant AuctionModule
    participant BankKeeper

    User->>AuctionModule: Place Bid
    AuctionModule->>AuctionModule: Calculate minBid based on last bid
    AuctionModule->>AuctionModule: Validate Bid
    AuctionModule->>BankKeeper: Transfer Coins
    BankKeeper-->>AuctionModule: Transfer Confirmation
    AuctionModule-->>User: Bid Confirmation

Loading

Poem

In the auction's heart, bids take flight,
With minBid set just right,
Rewards and transfers, all in line,
Modules dance, coins do shine.
In leverage's realm, coins do flow,
From module to account, a seamless glow.
Code refined, the system's bright,
In blockchain's world, all is light.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4e7a578 and b47a5b8.

Files selected for processing (2)

• x/auction/keeper/rewards.go (2 hunks)
• x/leverage/keeper/oracle.go (1 hunks)

Additional comments not posted (2)

x/auction/keeper/rewards.go (1)

76-76: Ensure that minBid is correctly updated from the last bid amount.

x/leverage/keeper/oracle.go (1)

300-300: Ensure that the new method SendCoinsFromModuleToAccount is used correctly for transferring coins.