fix: misscounters grpc-web get api #2547
Conversation
* fix: fix the auction creation in every block * ++ * set auction id 0 on query
* fix the amount collect to reward auction fee collector
WalkthroughThese changes primarily enhance logging capabilities across different modules and optimize how miss counters are retrieved. The updates aim to improve transparency and diagnostic capabilities in the system by introducing detailed logs for various operations and simplifying the process of fetching data. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Keeper
participant Oracle as Oracle Module
participant Auction as Auction Module
User->>Keeper: Request to Accrue Interest
Keeper->>Oracle: Log rewards for Oracle
Keeper->>Auction: Log rewards for Auction
Keeper->>Keeper: AccrueAllInterest processing
Keeper->>Keeper: fundModules(toOracle, toAuction)
Keeper->>Oracle: Check toOracle
Keeper->>Auction: Check toAuction
Note over Keeper: Use GetAllMissCounters in grpc_query.go
User->>Keeper: Request Miss Counters
Keeper->>Oracle: GetAllMissCounters
Oracle->>Keeper: Return Miss Counters
Keeper->>User: Provide Miss Counters
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2547 +/- ##
===========================================
- Coverage 75.38% 62.76% -12.63%
===========================================
Files 100 275 +175
Lines 8025 15950 +7925
===========================================
+ Hits 6050 10011 +3961
- Misses 1589 5165 +3576
- Partials 386 774 +388
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- x/leverage/keeper/interest.go (1 hunks)
- x/leverage/keeper/oracle.go (1 hunks)
- x/oracle/keeper/grpc_query.go (1 hunks)
- x/oracle/keeper/keeper.go (1 hunks)
Files skipped from review due to trivial changes (1)
- x/leverage/keeper/interest.go
Additional context used
GitHub Check: codecov/patch
x/oracle/keeper/grpc_query.go
[warning] 383-383: x/oracle/keeper/grpc_query.go#L383
Added line #L383 was not covered by testsx/oracle/keeper/keeper.go
[warning] 255-261: x/oracle/keeper/keeper.go#L255-L261
Added lines #L255 - L261 were not covered by tests
[warning] 263-263: x/oracle/keeper/keeper.go#L263
Added line #L263 was not covered by tests
Additional comments not posted (1)
x/leverage/keeper/oracle.go (1)
288-289: The updated logging statements in thefundModulesfunction enhance transparency by detailing the assets funded to oracle and auction modules. This is beneficial for debugging and auditing purposes.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- CHANGELOG.md (1 hunks)
Additional context used
LanguageTool
CHANGELOG.md
[grammar] ~117-~117: Using ‘plenty’ without ‘of’ is considered to be informal. (PLENTY_OF_NOUNS)
Context: .../pull/2368) Fix inflow amount calculation. Previously, the inflow amount of the t...
[grammar] ~219-~219: Did you mean “limiting”? Or maybe you should add a pronoun? In active voice, ‘allow’ + ‘to’ takes an object, usually a pronoun. (ALLOW_TO)
Context: ...veragedLiquidate.MaxRepay` which allows to limit the liquidation size using the leverage...
[grammar] ~352-~352: The singular proper name ‘Bridge’ must be used with a third-person or a past tense verb. (HE_VERB_AGR)
Context: ...-network/umee/pull/1967) Gravity Bridge phase out phase-2: disable Umee -> Ethereum t...
[grammar] ~353-~353: The singular proper name ‘Bridge’ must be used with a third-person or a past tense verb. (HE_VERB_AGR)
Context: ...-network/umee/pull/1967) Gravity Bridge phase out phase-2: disable Umee -> Ethereum t...
[grammar] ~403-~403: Make sure that the singular noun after the number ‘4.1’ is correct. (CD_POINT_CD_NN)
Context: ...e/pull/1807) Fixes BNB ibc denom in 4.1 migration - [1812](https://github.com/umee-networ...
[style] ~421-~421: In contexts where ‘if’ is followed by ‘or’, using ‘whether’ may be more appropriate (and formal). (IF_WHETHER)
Context: ...rowandMsgRepay` won't return errors if there is nothing to withdraw, borrow or...
[duplication] ~472-~472: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...e/pull/1555) Updates IBC to v5.1.0 that adds adds optional memo field to `FungibleTokenPa...
[uncategorized] ~529-~529: A comma may be missing after the conjunctive/linking adverb ‘Also’. (SENT_START_CONJUNCTIVE_LINKING_ADVERB_COMMA)
Context: ...ableLend, docs, and internal functions. Also QueryLoaned similar queries to QuerySup...
[misspelling] ~533-~533: This word is normally spelled as one. (EN_COMPOUNDS_PROTO_TYPES)
Context: ...roto getters in x/leverage and x/oracle proto types. - [1126](https://github.com/umee-netwo...
[duplication] ~652-~652: Possible typo: you repeated a word (ENGLISH_WORD_REPEAT_RULE)
Context: ...k/umee/pull/1358/files) Disable Gravity Bridge bridge messages. ### Improvements - [#1355](...
Additional comments not posted (1)
CHANGELOG.md (1)
67-67: Confirm the clarity and accuracy of the changelog entry for PR #2547.
|
LGTM |
Description
Previously this api is not showing the all validators miss counter , it will be fixed in this PR
Summary by CodeRabbit
Bug Fixes
MissCountersGRPC-Web API to correctly retrieve all miss counters.New Features
Refactor