Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:dynamic import as namespace import #1171

Merged
merged 18 commits into from
May 27, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented May 17, 2024

fix the problem

const {default: React} = await import("react")

before React is undefined

close #993

Summary by CodeRabbit

  • 新功能
    • BuildParams 结构体中添加了一个新字段 watch,包含一个可选的 ignoredPaths 字符串数组。
    • Config 结构体添加了一个新的 watch 字段。
    • profile_gui.rs 中改用 Compiler 替代 Notify,并基于编译器上下文参数调整初始化逻辑。
    • docs/config.md 中添加了一个新的配置选项 watch,用于在配置文件中指定要忽略监视的特定路径。
  • 修复
    • 修复了 watch_dir_recursive 方法,现在使用新的 get_ignore_list 方法动态生成忽略列表。
  • 文档
    • 更新了 mako.config.json 文件,为 Chrome 版本 40 添加了新的目标规范。
    • 更新了 @umijs/mako 包的版本,以及可选依赖项 @umijs/mako-darwin-arm64@umijs/mako-darwin-x64@umijs/mako-linux-x64-gnu 的版本。

Copy link
Contributor

coderabbitai bot commented May 17, 2024

Walkthrough

整体变更概述:在几个 crate 中增加了与监视文件系统相关的配置,调整了装饰器的顺序和一些结构的更新。

Changes

文件 变更概述
crates/binding/src/lib.rs 增加了 BuildParams 结构体中的 watch 字段,包含一个可选的 ignoredPaths 字符串数组。
crates/mako/src/build/transform.rs
crates/mako/src/config/config.rs
Transform 实现中添加了一个装饰器配置。
crates/mako/src/dev/watch.rs 重构了 Watcher 结构体中的 watch_dir_recursive 方法和其他相关方法。
crates/mako/src/main.rs 调整了对 dev 模块的引用,并修改了 run 函数内的操作。
crates/mako/src/utils/mod.rs 根据特性 "profile" 条件性地添加了一个新的 profile_gui 模块。
crates/mako/src/utils/profile_gui.rs 重构了 ProfileApp 结构体,将 Notify 替换为 Compiler
docs/config.md 添加了一个新的配置选项 watch,用于配置忽略的特定路径。
e2e/fixtures/javascript.legacy-decorator/expect.js
e2e/fixtures/javascript.legacy-decorator/mako.config.json
e2e/fixtures/javascript.legacy-decorator/src/index.ts
对 JavaScript 文件进行了一些更改。
packages/bundler-mako/package.json
packages/mako/npm/darwin-arm64/package.json
packages/mako/npm/darwin-x64/package.json
packages/mako/npm/linux-x64-gnu/package.json
packages/mako/package.json
更新了各个包的版本号。

Poem

兔子跃动编程间,

配置变更似春风。

装饰器添新彩,

版本号如歌长。

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

  • Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
  • Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
  • Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

  • Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
  • Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
  • High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
  • Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

Note

Free review on us!

CodeRabbit is offering free reviews until Mon May 27 2024 to showcase some of the refinements we've made.

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

stormslowly and others added 10 commits May 17, 2024 16:40
…1022)

* fix: fix "too many files open" error when watching with-antd example

* fix: include dist dictionary of root's parent dictionary when watching

---------

Co-authored-by: zp365238 <zp365238@antgroup.com>
Co-authored-by: pshu <pishu.spf@antfin.com>
…and watch mode (#1168)

* chore: 🔧 adjust puffin for easy profile for long time compiling

* refactor: 🎨 move profile logic to profile app
* test: ✅ add runtime assert in decorator and target to chrome 40

* fix: 🐛 move decorator before preset_env

* add comment on decorators
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 20a906e and 0bb3444.
Files selected for processing (1)
  • packages/mako/binding.d.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • packages/mako/binding.d.ts

@sorrycc sorrycc merged commit 5ad6f5f into master May 27, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/dynamic_import_as_namespace_import branch May 27, 2024 03:38
stormslowly added a commit that referenced this pull request May 27, 2024
stormslowly added a commit that referenced this pull request May 27, 2024
stormslowly added a commit that referenced this pull request May 27, 2024
stormslowly added a commit that referenced this pull request Jun 13, 2024
* Reapply "fix:dynamic import as namespace import (#1171)" (#1208)

This reverts commit 6e69d85.

* release: @umijs/mako@0.4.18-canary.20240528.5

* chore: ⬆️ update pnpm-lock

* release: @umijs/mako@0.5.5-canary.20240606.1

---------

Co-authored-by: Jinbao1001 <nodewebli@gmail.com>
Co-authored-by: sorrycc <sorrycc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] dynamic import should interop imported module
3 participants