fix: decorator visitor should run before preset env #1176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough总体变更概述：对构建过程、测试设置、优化配置和装饰器功能进行了调整和扩展。 Changes
Poem
Note Pull Request Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
sorrycc
reviewed
May 20, 2024
stormslowly
changed the title
sorrycc
approved these changes
May 20, 2024
stormslowly
added a commit
that referenced
this pull request
May 20, 2024
* test: ✅ add runtime assert in decorator and target to chrome 40 * fix: 🐛 move decorator before preset_env * add comment on decorators
sorrycc
added a commit
that referenced
this pull request
May 27, 2024
* feat: ✨ add [d]ynamic [r]equire runtime function * refactor: 🎨 dynamic import require process with interop * test: ✅ add test case * test: ✅ import context module adjust to dynamic import * release: @umijs/mako@0.4.18-canary.20240517.1 * chore: ⬆️ mako 0.4.18-canary.20240517.1 * chore: ⬆️ update pnpm-lock * typo * fix: fix "too many files open" error when watching with-antd example (#1022) * fix: fix "too many files open" error when watching with-antd example * fix: include dist dictionary of root's parent dictionary when watching --------- Co-authored-by: zp365238 <zp365238@antgroup.com> Co-authored-by: pshu <pishu.spf@antfin.com> * chore: 🔧 adjust puffin for easy profile for both long time compiling and watch mode (#1168) * chore: 🔧 adjust puffin for easy profile for long time compiling * refactor: 🎨 move profile logic to profile app * fix: decorator visitor should run before preset env (#1176) * test: ✅ add runtime assert in decorator and target to chrome 40 * fix: 🐛 move decorator before preset_env * add comment on decorators * feat: add watch.ignorePaths config (#1179) * release: @umijs/mako@0.4.18-canary.20240520.1 * chore: ⬆️ v0.4.18-canary.20240520.1 * chore: ⬆️ update pnpm-lock --------- Co-authored-by: zhangpanweb <37805064+zhangpanweb@users.noreply.github.com> Co-authored-by: zp365238 <zp365238@antgroup.com> Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if compile down to es5,
classbecomefunctions, then the decorator on the function will be removed silentlyref: #1172
Summary by CodeRabbit
Transform实现中更改了添加文件夹到folders向量的顺序，现在在swc_preset_env::preset_env之前添加了decorators文件夹。expect.js中的injectSimpleJest()函数调用和新的require("./dist/index.js")语句的添加。mako.config.json文件中为Chrome 40版本添加了新的目标规范。src/index.ts中为Foo类添加了装饰器@bar()，设置了类的属性bar，并添加了用于验证装饰器功能的测试。