feat: optimize lifecycle validation log (#2841)

umijs · Dec 21, 2023 · b2d2c11 · b2d2c11
1 parent 1cb6529
commit b2d2c11
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/.changeset/smart-scissors-press.md b/.changeset/smart-scissors-press.md
@@ -0,0 +1,6 @@
+---
+'qiankun': patch
+'@qiankunjs/sandbox': patch
+---
+
+feat: optimize lifecycle validate log
diff --git a/packages/qiankun/src/core/loadApp.ts b/packages/qiankun/src/core/loadApp.ts
@@ -6,7 +6,7 @@ import type { LoaderOpts } from '@qiankunjs/loader';
 import { loadEntry } from '@qiankunjs/loader';
 import type { Sandbox } from '@qiankunjs/sandbox';
 import { createSandboxContainer } from '@qiankunjs/sandbox';
-import { moduleResolver as defaultModuleResolver, transpileAssets, wrapFetchWithCache } from '@qiankunjs/shared';
+import { moduleResolver as defaultModuleResolver, transpileAssets, warn, wrapFetchWithCache } from '@qiankunjs/shared';
 import { concat, isFunction, mergeWith } from 'lodash';
 import type { ParcelConfigObject } from 'single-spa';
 import getAddOns from '../addons';
@@ -225,9 +225,7 @@ function getLifecyclesFromExports(
   }
 
   if (process.env.NODE_ENV === 'development') {
-    console.warn(
-      `[qiankun] lifecycle not found from ${appName} entry exports, fallback to get from window['${appName}']`,
-    );
+    warn(`lifecycle not found from ${appName} entry exports, fallback to get from window['${appName}']`);
   }
 
   // fallback to globalContext variable who named with ${appName} while module exports not found
@@ -237,7 +235,11 @@ function getLifecyclesFromExports(
     return globalVariableExports;
   }
 
-  throw new QiankunError(`You need to export lifecycle functions in ${appName} entry`);
+  throw new QiankunError(
+    `You need to export lifecycle functions in ${appName} entry as neither globalLatestSetProp ${String(
+      globalLatestSetProp,
+    )} nor window['${appName}'] export correctly`,
+  );
 }
 
 function calcPublicPath(entry: string): string {

diff --git a/packages/sandbox/src/patchers/dynamicAppend/common.ts b/packages/sandbox/src/patchers/dynamicAppend/common.ts
@@ -204,7 +204,7 @@ export function getOverwrittenAppendChildOrInsertBefore(
           const result = appendChild.call(this, transpiledScriptElement, refChild) as T;
 
           // the script have no src attribute after transpile, indicating that the script needs to wait for the src to be filled
-          if (externalSyncMode && !transpiledScriptElement.hasAttribute('scr')) {
+          if (externalSyncMode && !transpiledScriptElement.hasAttribute('src')) {
             queueSyncScript!();
           }