Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize lifecycle validation log #2841

Merged
merged 8 commits into from
Dec 21, 2023

Conversation

wanghangit
Copy link
Contributor

@wanghangit wanghangit commented Dec 12, 2023

Checklist
  • npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: 6d3a480

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
qiankun Patch
@qiankunjs/sandbox Patch
@qiankunjs/react Patch
@qiankunjs/vue Patch
@qiankunjs/loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 12, 2023

@wanghangit is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel.

@umijs first needs to authorize it.

@wanghangit wanghangit changed the title feat: add lifecycle check log at development environment (#2604) feat: add lifecycle check log at development environment Dec 12, 2023
packages/qiankun/src/core/loadApp.ts Outdated Show resolved Hide resolved
packages/qiankun/src/core/loadApp.ts Outdated Show resolved Hide resolved
packages/qiankun/src/core/loadApp.ts Outdated Show resolved Hide resolved
.changeset/long-radios-admire.md Outdated Show resolved Hide resolved
packages/qiankun/src/core/loadApp.ts Outdated Show resolved Hide resolved
packages/qiankun/src/core/loadApp.ts Outdated Show resolved Hide resolved
@kuitos kuitos changed the title feat: add lifecycle check log at development environment feat: optimize lifecycle validate log Dec 20, 2023
@@ -204,7 +204,7 @@ export function getOverwrittenAppendChildOrInsertBefore(
const result = appendChild.call(this, transpiledScriptElement, refChild) as T;

// the script have no src attribute after transpile, indicating that the script needs to wait for the src to be filled
if (externalSyncMode && !transpiledScriptElement.hasAttribute('scr')) {
if (externalSyncMode && !transpiledScriptElement.hasAttribute('src')) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里看代码应该是拼错顺手改了

@kuitos kuitos changed the title feat: optimize lifecycle validate log feat: optimize lifecycle validation log Dec 21, 2023
Copy link
Member

@kuitos kuitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kuitos kuitos merged commit b2d2c11 into umijs:next Dec 21, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants