-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: optimize lifecycle validation log #2841
Conversation
🦋 Changeset detectedLatest commit: 6d3a480 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@wanghangit is attempting to deploy a commit to a Personal Account owned by @umijs on Vercel. @umijs first needs to authorize it. |
@@ -204,7 +204,7 @@ export function getOverwrittenAppendChildOrInsertBefore( | |||
const result = appendChild.call(this, transpiledScriptElement, refChild) as T; | |||
|
|||
// the script have no src attribute after transpile, indicating that the script needs to wait for the src to be filled | |||
if (externalSyncMode && !transpiledScriptElement.hasAttribute('scr')) { | |||
if (externalSyncMode && !transpiledScriptElement.hasAttribute('src')) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里看代码应该是拼错顺手改了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Checklist
npm test
passesDescription of change
在所有方式获取lifecycle都不合法时,对错误提示进行优化,输出每种方式错误的lifecycle