CLDR-17304 expand logKnownIssues to quell remaining SEVERE errors #3513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updates LogKnownIssues to CLDR-17320 to catch all other cases
srl295
requested review from
macchiati,
AEApple,
btangmu,
pedberg-icu and
DraganBesevic
pedberg-icu
reviewed
Feb 23, 2024
tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCheckCLDR.java
Outdated
Show resolved
Hide resolved
|
yes thanks!
…On Fri, Feb 23, 2024 at 11:18 AM Peter Edberg ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCheckCLDR.java
<#3513 (comment)>:
> oldLevel = CheckCLDR.setLoggerLevel(java.util.logging.Level.OFF);
}
+ return oldLevel;
+ }
+
+ /** undo the effect of a popCheckLevel */
Shouldn't this be "undo the effect of a pushCheckLevel" ?
—
Reply to this email directly, view it on GitHub
<#3513 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGQZM5LJGPM6MG7FMV2FWTYVDFODAVCNFSM6AAAAABDXBBTH6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQOJYGU4TGOJSHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
btangmu
reviewed
Feb 23, 2024
- fix typo in comment per review comment
btangmu
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17304
This quells the rest of the SEVERE errors and stacktraces as a logKnownIssue. There was already a logKnownIssue in place, this just expands it to apply to the other callers.
ALLOW_MANY_COMMITS=true