Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17304 expand logKnownIssues to quell remaining SEVERE errors #3513

Merged
merged 2 commits into from
Feb 23, 2024
Merged

CLDR-17304 expand logKnownIssues to quell remaining SEVERE errors #3513

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc40566
CLDR-17304 expand logKnownIssues to quell remaining SEVERE errors
srl295 Feb 23, 2024
27e2756
CLDR-17304 expand logKnownIssues to quell remaining SEVERE errors
srl295 Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestCheckCLDR.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,13 +467,26 @@ public void TestFullErrors() {
checkLocale(test, localeID, "?", null);
}

public void TestAllLocales() {
/** adjust the logging level of checks */
public java.util.logging.Level pushCheckLevel() {
java.util.logging.Level oldLevel = null;
if (logKnownIssue(
"CLDR-17320",
"turning off CheckCLDR logging to avoid 2,000 log messages, please fix internal stack traces")) {
"turning off CheckCLDR logging to avoid thousands of log messages, please fix internal stack traces")) {
oldLevel = CheckCLDR.setLoggerLevel(java.util.logging.Level.OFF);
}
return oldLevel;
}

/** undo the effect of a pushCheckLevel */
public void popCheckLevel(java.util.logging.Level oldLevel) {
if (oldLevel != null) {
CheckCLDR.setLoggerLevel(oldLevel);
}
}

public void TestAllLocales() {
java.util.logging.Level oldLevel = pushCheckLevel();
CheckCLDR test = CheckCLDR.getCheckAll(factory, INDIVIDUAL_TESTS);
CheckCLDR.setDisplayInformation(english);
Set<String> unique = new HashSet<>();
Expand All @@ -493,18 +506,18 @@ public void TestAllLocales() {
// (And in fact this test seems faster without it)
locales.forEach(locale -> checkLocale(test, locale, null, unique));
logln("Count:\t" + locales.size());
if (oldLevel != null) {
CheckCLDR.setLoggerLevel(oldLevel);
}
popCheckLevel(oldLevel);
}

public void TestA() {
final java.util.logging.Level oldLevel = pushCheckLevel();

CheckCLDR test = CheckCLDR.getCheckAll(factory, INDIVIDUAL_TESTS);
CheckCLDR.setDisplayInformation(english);
Set<String> unique = new HashSet<>();

checkLocale(test, "ko", null, unique);
popCheckLevel(oldLevel);
}

public void checkLocale(
Expand Down
Loading