Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22087 Export a non-recursive canonical decomposition supplement for ICU4X #2130

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

hsivonen
Copy link
Member

@hsivonen hsivonen commented Jul 12, 2022

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22087
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Tests are in unicode-org/icu4x#2099

@markusicu markusicu self-requested a review July 14, 2022 16:06
@hsivonen hsivonen marked this pull request as ready for review July 15, 2022 06:45
@@ -532,12 +532,17 @@ void computeDecompositions(const char* basename, const USet* backwardCombiningSt
IcuToolErrorCode status("icuexportdata: computeDecompositions");
Copy link
Member

@sffc sffc Jul 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion (optional):

  1. Change this function to take nonRecursive32 and nonRecursiveBuilder as arguments, or move it to a new function called computeDecompositionsInner
  2. Create a new function computeDecompositionsAndWriteNonRecursive and move the file-writing machinery to it
  3. At the call site, change computeDecompositions("nfd", ...) to computeDecompositionsAndWriteNonRecursive("nfd", ...)

@sffc sffc merged commit 9c72bf9 into unicode-org:main Jul 18, 2022
@sffc sffc deleted the icu4x-rawdecomposition branch July 18, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants