Provide raw canonical composition and decomposition #2099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use named constants instead of magic numbers. * Use wrapping_sub with HANGUL_S_BASE. (Couldn't find a way to trigger a debug-mode overflow without this, though.)
|
I've compared every decomposition with ICU4C. |
Merged
7 tasks
|
The CI failures seem to be rust-lang/rustup#3029 |
hsivonen
requested review from
a team,
sffc,
robertbastian and
Manishearth
as code owners
|
Marked ready for review, because the CI failures don't seem to be caused by the changes here. |
sffc
previously approved these changes
Jul 16, 2022
|
This can't land until the backport of the ICU4C patch has landed to the maintenance branch. |
sffc
approved these changes
Jul 18, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft due to missing tests. Closes #2073.