-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data and provider for compact decimal formatting #2883
Data and provider for compact decimal formatting #2883
Conversation
c51d259
to
22097a2
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
CI fails because of Swahili. Supporting
|
We had a similar issue in the list formatter, we fixed it in CLDR and added a special case in datagen. |
Yes, for both this and the scientific stuff we should just add some fixup hacks in datagen until cldr gets fixed |
Please merge in |
I did, and I cannot, see #2897 (comment); reinstated into_iter1 on @Manishearth’s advice. |
Codecov Report
@@ Coverage Diff @@
## main #2883 +/- ##
==========================================
+ Coverage 73.66% 73.78% +0.12%
==========================================
Files 458 464 +6
Lines 39185 39596 +411
==========================================
+ Hits 28866 29217 +351
- Misses 10319 10379 +60
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but let's make another PR to remove into_iter1
again
Never-mind: All OK |
Towards #1267.