Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data and provider for compact decimal formatting #2883
Data and provider for compact decimal formatting #2883
Changes from all commits
0f2b754
1debe59
f1760a1
d5657bf
8b0f103
4d9f95f
43fe38e
aa6dc5c
507e234
a5b63f6
a0db0c9
12bebe4
7e60fe1
0c25367
5f5db46
3dfd5bf
9537951
b9f1405
9ff37a2
22097a2
09cdad5
addb602
b9309e7
21a35cf
7373756
1c17a74
e9c7bb1
89c14cb
a980ac0
5265ca9
0f3ce45
dd8616c
0b693bc
8bbc3b2
7127e5f
193e9b3
03afa3e
8285b0a
b09a5e3
8d9f94d
4a39f6b
5fbd7c1
4c92089
35d0180
2b55276
64ca7a8
5b44901
31d35b3
ad61326
c6e3d9d
3c6aa71
3e6086b
5b243bd
4305c73
ddb3bae
60b9843
e94c2ce
e16100a
9d95dae
41d817f
b4336aa
0761f89
061953d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enum should is representing the general
Count
for any plural rules, for example in currency or units, we will needCount
too.Therefore, I think
Count
implementation should be in some central place that we can use it, instead of writing this implementation for each component.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah; for now let's duplicate it but we should figure out a common solution. I don't want to over-engineer this given that we're waiting on icu_pattern which is intended to be the common solution (@zbraniecki)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is pattern related to this enum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The enum is input into the pattern selection, which I imagine may influence the design of the enum