Allow noncompact CompactDecimal #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
requested changes
Dec 14, 2022
|
Also please add docs to the two new functions |
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
Co-authored-by: Shane F. Carr <shane@unicode.org>
sffc
previously approved these changes
Dec 14, 2022
|
Bumping CI |
|
Manishearth
previously approved these changes
Dec 16, 2022
| @@ -92,10 +136,6 @@ fn test_compact_syntax_error() { | |||
| pub expected_err: Option<Error>, | |||
| } | |||
| let cases = [ | |||
| TestCase { | |||
There was a problem hiding this comment.
nit: probably add some testcases that ensure it works now
There was a problem hiding this comment.
They are in the doc tests (and they even caught a hint bug); the #[test] only covers errors.
Manishearth
approved these changes
Dec 16, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @sffc; towards #1267.