refactor(cloudflare): make node:util/types a nodejs_compat module

[anonrig]

All methods in util/types are implemented. We can remove the hybrid module status from node:util/types

[vicb]

What workerd version this PR depends on?

We can not pull this code in wrangler before wrangler pulls the required version of workerd.

More generally I think we should use whatever workerd version is bundled with wrangler for the tests. Having a different version is a recipe for troubles.

@anonrig that's probably something we need to discuss internally.

[pi0]

I think we discussed about it to split wrangler preset/versioning so we can test and upgrade unenv according to the latest workerd release.

[vicb]

I think we discussed about it to split wrangler preset/versioning so we can test and upgrade unenv according to the latest workerd release.

Are you referring to #262?

I think the problem we need to solve for wrangler is how to make sure unenv is compatible/tested with the version version of workerd it uses.

I'm unsure if creating a wrangler preset is the best way to solve this - hopefully this repo is never aware about wrangler. What I mean is that unenv patches should depend on workerd version, not wrangler version. When we have a way to do that then wrangler will pick the unenv version matching the workerd version it bundles.

[pi0]

• yes issue you mentioned is related -- we talked further in meeting about separating fully + npm tag for workerd
• in unenv, we test against latest published workerd on npm
• idea is that, workerd has a tag about the production version so wrangler tests against that
• I think we probably should discuss it off this PR

[anonrig]

What workerd version this PR depends on?

This change was released almost 4 months ago - cloudflare/workerd@799dfbe. The change is first introduced in v1.20240614.0. @vicb

[anonrig]

More generally I think we should use whatever workerd version is bundled with wrangler for the tests. Having a different version is a recipe for troubles.

@vicb I agree. In the long term, we should match those 2 version. Right now, wrangler main and unenv main has different workerd version.

[vicb]

More generally I think we should use whatever workerd version is bundled with wrangler for the tests. Having a different version is a recipe for troubles.

@vicb I agree. In the long term, we should match those 2 version. Right now, wrangler main and unenv main has different workerd version.

Maybe we should have 2 tags for workerd: "prod" and "wrangler" and test both versions.

[pi0]

Thank you ❤️

Feel free to merge when/if prod version of workerd shipped this