Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove Windows.Foundation.IClosable and Deferral.Close #11163

Merged

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): Part of #8339

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

BREAKING CHANGE: In UWP, `IClosable` appears as System.IDisposable. The interface is now removed along with `Deferral.Close` which was implementing the interface.
@Youssef1313 Youssef1313 changed the base branch from master to feature/breaking-changes February 2, 2023 13:12
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Feb 2, 2023
@Youssef1313
Copy link
Member Author

I'm going to merge as this has 3 approvals already :)

@Youssef1313 Youssef1313 merged commit 2b62b58 into unoplatform:feature/breaking-changes Feb 5, 2023
@Youssef1313 Youssef1313 deleted the deferral-close branch February 5, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants