Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove wrong GetGeopositionHistoryAsync overloads from Geolocator #11198

Merged

Conversation

Youssef1313
Copy link
Member

BREAKING CHANGE: Remove GetGeopositionHistoryAsync overloads that always returned empty list and don't match Windows signatures

GitHub Issue (If applicable): Part of #8339

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

…cator`

BREAKING CHANGE: Remove `GetGeopositionHistoryAsync` overloads that always returned empty list and don't match Windows signatures
@github-actions github-actions bot added platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform labels Feb 5, 2023
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Feb 6, 2023
@Youssef1313 Youssef1313 merged commit 2ea67b9 into unoplatform:feature/breaking-changes Feb 6, 2023
@Youssef1313 Youssef1313 deleted the geolocator branch February 6, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants