Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Remove constructor overloads that takes an unused args parameter #11351

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): #8339

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

BREAKING CHANGE: `FrameBufferHost` and `GtkHost` constructors that takes `args` are now removed. `args` were already unused.
@github-actions github-actions bot added area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia labels Feb 16, 2023
@jeromelaban jeromelaban merged commit 1b885da into unoplatform:feature/breaking-changes Feb 17, 2023
@Youssef1313 Youssef1313 deleted the args branch February 17, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants