Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Move SwipeControl to MUX #12112

Merged

Conversation

Youssef1313
Copy link
Member

BREAKING CHANGE: Move SwipeControl, SwipeItem, SwipeItemInvokedEventArgs, SwipeMode, SwipeItems, and SwipeBehaviorOnInvoked implementation from WUX namespace to MUX namespace.

GitHub Issue (If applicable): Part of #8339

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 marked this pull request as ready for review May 8, 2023 19:23
@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label May 8, 2023
@jeromelaban
Copy link
Member

I don't think we need to do that one. It's already in the proper namespace when running for WinUI, so that would be an unnecessary change for the UWP targets. What do you think @MartinZikmund ?

@MartinZikmund
Copy link
Member

@jeromelaban I think it is still relevant for UWP as well - similarly to other controls like NavigationView, SwipeControl and others are more up-to-date and have latest fixes in WinUI 2.8, so apps targeting UWP will most likely use the MUX version it instead of the WUX version. When porting such apps, it would mean the developer would have to make a uno-specific XAML to include both MUX version on UWP and WUX version on Uno targets, which would be quite ugly. Alternative solution would be to copy the same implementation to both MUX and WUX namespace, but I assume most people will no longer use WUX version anyway, so this should be simpler.

BREAKING CHANGE: Move `SwipeControl`, `SwipeItem`, `SwipeItemInvokedEventArgs`, `SwipeMode`, `SwipeItems`, and `SwipeBehaviorOnInvoked` implementation from WUX namespace to MUX namespace.
@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label May 13, 2023
@Youssef1313
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@jeromelaban
Copy link
Member

Some tests are failing it seems:
image

@jeromelaban jeromelaban marked this pull request as draft May 15, 2023 17:51
@Youssef1313 Youssef1313 marked this pull request as ready for review May 16, 2023 10:38
Copy link
Member

@MartinZikmund MartinZikmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolington!

Copy link
Member

@MartinZikmund MartinZikmund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coolington!

@MartinZikmund MartinZikmund merged commit 3a33b26 into unoplatform:feature/breaking-changes May 31, 2023
@Youssef1313 Youssef1313 deleted the swipe-control branch May 31, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/build Categorizes an issue or PR as relevant to build infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants