-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Move SwipeControl to MUX #12112
fix!: Move SwipeControl to MUX #12112
Conversation
7c036c9
to
a4309f2
Compare
d5fe12a
to
d5f223d
Compare
I don't think we need to do that one. It's already in the proper namespace when running for WinUI, so that would be an unnecessary change for the UWP targets. What do you think @MartinZikmund ? |
@jeromelaban I think it is still relevant for UWP as well - similarly to other controls like |
BREAKING CHANGE: Move `SwipeControl`, `SwipeItem`, `SwipeItemInvokedEventArgs`, `SwipeMode`, `SwipeItems`, and `SwipeBehaviorOnInvoked` implementation from WUX namespace to MUX namespace.
dcd1d7e
to
edc2826
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolington!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coolington!
BREAKING CHANGE: Move
SwipeControl
,SwipeItem
,SwipeItemInvokedEventArgs
,SwipeMode
,SwipeItems
, andSwipeBehaviorOnInvoked
implementation from WUX namespace to MUX namespace.GitHub Issue (If applicable): Part of #8339
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):