Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] perf: Brush change subscription #12595

Closed
wants to merge 2 commits into from

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Jun 9, 2023

GitHub Issue (If applicable): closes #

Replaces #12234

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Copilot Summary

🤖 Generated by Copilot at 9032c90

This pull request improves the performance and memory usage of the brush system by adding a new feature to Brush.cs that allows subscribing to brush changes without creating new delegates or closures. It also simplifies and refactors the using directives and the brush change handling in TextBlock.cs and TextBox.cs. It moves some types to separate files for clarity and consistency. It updates the Brush.skia.cs and SolidColorBrush.cs files to use the new feature.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Jun 9, 2023
@mergify mergify bot mentioned this pull request Jun 9, 2023
6 tasks
@MartinZikmund MartinZikmund self-assigned this Jun 9, 2023
@jeromelaban jeromelaban changed the base branch from feature/5x to master June 29, 2023 15:32
@MartinZikmund
Copy link
Member Author

Closing in favor of #12896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant