UserControl fixes #3279
Merged
UserControl fixes #3279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jeromelaban
force-pushed
the
dev/jela/usercontrol-restore
branch
from
559542c
to
5c7e86a
Compare
jeromelaban
force-pushed
the
dev/jela/usercontrol-restore
branch
from
5c7e86a
to
1a95506
Compare
davidjohnoliver
approved these changes
Jun 1, 2020
src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlCodeGeneration.cs
Show resolved
Hide resolved
jeromelaban
force-pushed
the
dev/jela/usercontrol-restore
branch
from
1a95506
to
6359cf2
Compare
|
|
|
The build 15952 found UI Test snapshots differences.
|
|
The build 15958 found UI Test snapshots differences.
|
|
The build 15958 found UI Test snapshots differences.
|
|
The build 15958 found UI Test snapshots differences.
|
…lf, not the first child Fixes #3243
BREAKING CHANGE: This update now forces the materialization of UserControl instances in the visual tree. - UserControl no longer incorrectly accepts VisualStateManager, and must be placed on the first child - To restore the skipping of UserControl instances, add the following in the csproj: ```xml <UnoSkipUserControlsInVisualTree>true</UnoSkipUserControlsInVisualTree> ``` Fixes #61
jeromelaban
force-pushed
the
dev/jela/usercontrol-restore
branch
from
6359cf2
to
481f20c
Compare
...ts/Windows_UI_XAML_Controls/UserControlTests/UserControl_TopLevelBinding_UserControl.xaml.cs
Show resolved
Hide resolved
|
|
||
| public static void SetMyProperty(DependencyObject obj, int value) | ||
| { | ||
| obj.SetValue(MyPropertyProperty, value); |
There was a problem hiding this comment.
|
The build 15995 found UI Test snapshots differences.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): Fixes #3243, Fixes #61, Fixes #3218, Fixes #153
PR Type
What kind of change does this PR introduce?
What is the new behavior?
UserControlinstances are now placed in the visual tree by default.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Contains NO breaking changesOther information
Internal Issue (If applicable):