-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Android implementation for Windows.Data.Pdf #9718
feat: Android implementation for Windows.Data.Pdf #9718
Conversation
f334ae4
to
8145420
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice !
src/Uno.UI.RuntimeTests/Tests/Windows_Data/Pdf/Given_PdfDocument.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.RuntimeTests/Tests/Windows_Data/Pdf/Given_PdfDocument.cs
Outdated
Show resolved
Hide resolved
src/Uno.UI.RuntimeTests/Tests/Windows_Data/Pdf/Given_PdfDocument.cs
Outdated
Show resolved
Hide resolved
23e3f02
to
bafcdc3
Compare
bee33ce
to
683795f
Compare
What did I forget to answer? I seem to have applied all the review comments. |
The build was not passing at that time, we'll need to review the Sample from the APK now :) |
e4ddcb6
to
5c781a6
Compare
I've checked quickly the samples app on a device, and it works! Very nice! It should be interesting to make sure that the ScrollViewer that show the document is able to scroll horizontally, otherwise it's cropped. I'm not too sure about the API, but is there a way to show the pdf originally scaled to the available view size? |
I have applied your suggestions. What are the doubts about implementing the API? |
dc37b32
to
8929d15
Compare
8929d15
to
2efc20c
Compare
can someone restart the CI? |
a1e526d
to
9a1fbf7
Compare
Very nice! It's getting there! Two observations:
|
Thanks for the review, |
9a1fbf7
to
19f2414
Compare
I verified.
|
19f2414
to
9258186
Compare
9258186
to
a6502b4
Compare
a9e19ac
to
e37c3e8
Compare
3548f70
to
e5e245e
Compare
a513dd9
to
ad6ec72
Compare
@workgroupengineering thanks for taking the time to rebase on master! We'll take a look again and see if there's anything else to adjust. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking very good! Just one small adjustment and we can merge this!
bf11cf6
to
1c9931b
Compare
Inport initial implementation from PR unoplatform#1796
1c9931b
to
60dc7c7
Compare
GitHub Issue (If applicable): Part of #1629 (This PR implements Android only), closes #1796
PR Type
What kind of change does this PR introduce?
What is the current behavior?
not impemented
What is the new behavior?
implementation for Windows.Data.Pdf on Android continuation of #1796
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):