Android implementation for Windows.Data.Pdf #1796

artemious7 · 2019-10-10T14:43:50Z

GitHub Issue (If applicable): #1629

PR Type

What kind of change does this PR introduce?

Feature

What is the current behavior?

No implementation for Windows.Data.Pdf

What is the new behavior?

Added implementation for Windows.Data.Pdf for Android (where a correspondent APIs available).
Added extensions to convert Stream to IRandomAccessStream and vice versa (which is not a real implementation, but just a stub to pass Stream to methods accepting only IRandomAccessStream).

PR Checklist

Please check if your PR fulfills the following requirements:

Tested code with current supported SDKs
(not sure what current supported SDKs means, but I have tested it on my Android project)
Docs have been added/updated which fit documentation template (for bug fixes / features)
Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
Contains NO breaking changes
Updated the Release Notes
Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

update from source

update PdfDocument-branch from source

jeromelaban

Very nice PR, thank you for your contribution !

A few things:

You'll need to update the release notes
You'll need to add a article that explains the available features and limitations of the current implementation (see https://github.com/unoplatform/uno/tree/master/doc/articles/features).
A UI Test is important for that, and it may be an easy one to do. Embed a PDF file in the sample app, make it render and compare the resulting render with a master file (see https://github.com/unoplatform/uno/blob/master/doc/articles/uno-development/working-with-the-samples-apps.md#creating-ui-tests).

jeromelaban · 2019-10-11T12:30:10Z

src/Uno.UWP/Data/Pdf/PdfDocument.Droid.cs

@@ -0,0 +1,81 @@
+#if __ANDROID__


This file should be named ".android.cs", so that the globbing picks it up:

uno/src/PlatformItemGroups.props

Line 70 in a6db376

<None Include="**\*.Android.cs" Exclude="bin\**\*.Android.cs;obj\**\*.Android.cs" />

sorry, I used ".Droid.cs" naming convention from here

I made a PR to fix the docs

jeromelaban · 2019-10-11T12:31:43Z

src/Uno.UWP/Data/Pdf/PdfDocument.Droid.cs

+
+namespace Windows.Data.Pdf
+{
+	public partial class PdfDocument : IDisposable


Please make sure that the .editorconfig file is used, so that it aligns with the global whitespace configuration.

Ok, I applied Code Cleanup, but for some reason it removes whitespace before #if conditions

jeromelaban · 2019-10-11T12:32:42Z

src/Uno.UWP/Data/Pdf/PdfDocument.Droid.cs

+			pdfRenderer.Dispose();
+		}
+
+		private readonly PdfRenderer pdfRenderer;


Please place fields at the top of the file

jeromelaban · 2019-10-11T12:34:28Z

src/Uno.UWP/Data/Pdf/PdfPage.Droid.cs

+			{
+				throw new ArgumentNullException(nameof(options));
+			}
+			if (options.DestinationWidth > int.MaxValue)


use braces for single line conditions. (See .editorconfig file)

jeromelaban · 2019-10-11T12:37:10Z

src/Uno.UWP/Data/Pdf/PdfPage.Droid.cs

+			pdfPage.Dispose();
+		}
+
+		private static RectF AsAndroidRectF(Rect rect) => new RectF(


Move this here:

uno/src/Uno.Foundation/Rect.Android.cs

Line 10 in a6db376

public partial struct Rect

jeromelaban · 2019-10-11T12:39:54Z

src/Uno.UWP/Uno.csproj

@@ -38,6 +38,15 @@
 	<ItemGroup>
 		<UpToDateCheckInput Include="**\*.cs" Exclude="bin\**\*.cs;obj\**\*.cs;" />
 	</ItemGroup>
+
+	<ItemGroup>


Please remove, caused by an android issue.

jeromelaban · 2019-10-11T12:40:47Z

src/Uno.UWP/System.IO/WindowsRuntimeStreamExtensions.cs

+			{
+				return wrapper.GetSourceStream();
+			}
+			else throw new ArgumentException($"stream must be a {nameof(RandomAccessStreamWrapper)}", nameof(stream));


Braces even for single line conditions

Added to docs PR over at https://github.com/unoplatform/uno/pull/1212/files#diff-336e4bcde45e4393a322cd34f381311dR35

artemious7 · 2019-10-14T18:05:02Z

Fixed issues in code, but CI build still fails

jeromelaban · 2019-10-15T13:08:36Z

The CI fails for a good reason now:

There are changes made to the classes that make for breaking changes. Ctors changes may be valid, you'd have to check in UWP to see if there are defaults ctors. For the missing extension methods, this has to be fixed.

CLAassistant · 2020-06-10T01:50:37Z

All committers have signed the CLA.

MartinZikmund · 2021-07-18T10:55:25Z

@artemious7 are you able to rebase this PR to resolve the conflicts and check the build errors please?

MartinZikmund · 2022-02-23T12:35:06Z

@artemious7 Hi, can you still get to this PR to bring it up to date please?

artemious7 · 2022-02-23T20:36:09Z

@MartinZikmund, no, sorry, I don't have the time recently and I don't use this code.

…1796

Inport initial implementation from PR unoplatform#1796

artemious7 added 11 commits August 12, 2019 22:19

Merge pull request #1 from unoplatform/master

b7c0f59

update from source

Merge pull request #2 from unoplatform/master

a8bb1fc

update from source

started implementing PdfDocument on Android

1ef537f

move new files to separate folder

614feed

PdfDocument and PdfPage for Android

0a5f0b9

revert deleting Windows.Data.pDf files from Generated folder

f2d036f

added .Droid suffix. __ANDROID__ to false in Generated files

7e2a75e

Merge pull request #5 from unoplatform/master

5a17f7d

update PdfDocument-branch from source

restored Generated files that were removed

9828260

added partial keyword for 2 classes

fc35be0

added #if __ANDROID__ in PdfPageRenderOptions.cs

2892723

jeromelaban reviewed Oct 11, 2019

View reviewed changes

artemious7 added 6 commits October 14, 2019 11:55

renamed .Droid.cs to .Android.cs

778e765

fixed whitespacing with CodeCleanup

7e117b0

place fields at the top of the file

ca4bfb8

braces for single line conditions and 'var' instead of explicit types

d40dc40

explicit operator: Windows.Foundation.Rect to Android.Graphics.RectF

b6de86a

remove lines in Uno.csproj (which were caused by an android issue)

4e0d166

removed lines from Uno.csproj

c2caf11

ghuntley added platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform kind/enhancement New feature or request labels Oct 14, 2019

added braces for 'if' statement

e251b64

artemious7 requested a review from a team August 7, 2020 22:11

MartinZikmund marked this pull request as draft February 23, 2022 12:35

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Sep 10, 2022

feat(PdfDocument): Inport initial implementation from PR unoplatform#…

3475e4b

…1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Sep 27, 2022

feat(PdfDocument): Inport initial implementation from PR unoplatform#…

c202708

…1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Oct 17, 2022

feat(PdfDocument): Inport initial implementation from PR unoplatform#…

5cf232b

…1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Oct 18, 2022

feat(PdfDocument): Inport initial implementation from PR unoplatform#…

cc08eb0

…1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Oct 26, 2022

feat(PdfDocument): Inport initial implementation from PR unoplatform#…

4aaa210

…1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Nov 2, 2022

feat(PdfDocument): Inport initial implementation from PR unoplatform#…

9228927

…1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Nov 14, 2022

feat(PdfDocument): Inport initial implementation from PR unoplatform#…

fb3aad5

…1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Nov 30, 2022

feat(PdfDocument): Inport initial implementation from PR unoplatform#…

9a2699a

…1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Dec 14, 2022

feat(PdfDocument): Inport initial implementation from PR unoplatform#…

0d2f7c3

…1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Feb 8, 2023

feat: [Android] PdfDocument

c75e2f1

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Feb 8, 2023

feat: [Android] PdfDocument

beaef22

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Feb 8, 2023

feat: [Android] PdfDocument

2495fc0

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Feb 23, 2023

feat: [Android] PdfDocument

207788b

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Mar 7, 2023

feat: [Android] PdfDocument

b86d796

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Mar 11, 2023

feat: [Android] PdfDocument

319ea60

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Mar 14, 2023

feat: [Android] PdfDocument

2bd0814

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Mar 24, 2023

feat: [Android] PdfDocument

f67c994

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Mar 24, 2023

feat: [Android] PdfDocument

a9db106

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Apr 5, 2023

feat: [Android] PdfDocument

85db990

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Apr 14, 2023

feat: [Android] PdfDocument

209df7b

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Apr 17, 2023

feat: [Android] PdfDocument

367b7ff

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request May 2, 2023

feat: [Android] PdfDocument

90ebfb4

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request May 2, 2023

feat: [Android] PdfDocument

df00ae9

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request May 8, 2023

feat: [Android] PdfDocument

9ec0c95

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Jun 30, 2023

feat: [Android] PdfDocument

73057d6

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Jun 30, 2023

feat: [Android] PdfDocument

e58cc42

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Jul 28, 2023

feat: [Android] PdfDocument

ff6aa92

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Jul 28, 2023

feat: [Android] PdfDocument

8afa51e

Inport initial implementation from PR unoplatform#1796

workgroupengineering pushed a commit to workgroupengineering/uno that referenced this pull request Jul 28, 2023

feat: [Android] PdfDocument

092f078

Inport initial implementation from PR unoplatform#1796

jeromelaban closed this in #9718 Jul 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android implementation for Windows.Data.Pdf #1796

Android implementation for Windows.Data.Pdf #1796

artemious7 commented Oct 10, 2019 •

edited

Loading

jeromelaban left a comment

jeromelaban Oct 11, 2019

artemious7 Oct 14, 2019

artemious7 Oct 14, 2019

jeromelaban Oct 11, 2019

artemious7 Oct 14, 2019

jeromelaban Oct 11, 2019

jeromelaban Oct 11, 2019

jeromelaban Oct 11, 2019

jeromelaban Oct 11, 2019

jeromelaban Oct 11, 2019

ghuntley Oct 14, 2019 •

edited

Loading

artemious7 commented Oct 14, 2019

jeromelaban commented Oct 15, 2019

CLAassistant commented Jun 10, 2020 •

edited

Loading

MartinZikmund commented Jul 18, 2021

MartinZikmund commented Feb 23, 2022

artemious7 commented Feb 23, 2022

Android implementation for Windows.Data.Pdf #1796

Android implementation for Windows.Data.Pdf #1796

Conversation

artemious7 commented Oct 10, 2019 • edited Loading

PR Type

What is the current behavior?

What is the new behavior?

PR Checklist

Other information

jeromelaban left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghuntley Oct 14, 2019 • edited Loading

Choose a reason for hiding this comment

artemious7 commented Oct 14, 2019

jeromelaban commented Oct 15, 2019

CLAassistant commented Jun 10, 2020 • edited Loading

MartinZikmund commented Jul 18, 2021

MartinZikmund commented Feb 23, 2022

artemious7 commented Feb 23, 2022

artemious7 commented Oct 10, 2019 •

edited

Loading

ghuntley Oct 14, 2019 •

edited

Loading

CLAassistant commented Jun 10, 2020 •

edited

Loading