Setup a Pull Request template to the site #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnm678
approved these changes
Oct 24, 2023
hexsecs
approved these changes
Oct 24, 2023
jhdalek55
requested changes
Oct 24, 2023
Co-authored-by: Lois Anne DeLong <lad278@nyu.edu>
Co-authored-by: Lois Anne DeLong <lad278@nyu.edu>
jhdalek55
approved these changes
Oct 24, 2023
Abhijay007
requested changes
Oct 24, 2023
|
|
||
| ## Checklist | ||
|
|
||
| - [ ] I have read and followed the [project's contribution guidelines](https://github.com/secure-systems-lab/lab-guidelines/blob/master/dev-workflow.md), including code style and commit message conventions. |
There was a problem hiding this comment.
I think these contribution guidelines are not associated with uptane project
There was a problem hiding this comment.
The secure-systems-lab is out of the NYU team that leads Uptane. It may be more advantageous to copy the guidelines to our own site and link directly.
There was a problem hiding this comment.
@Abhijay007 I'm ok keeping the current text and flagging it for improvement later.
There was a problem hiding this comment.
ya that works, we can create a separate issue for this
|
I'm going to merge this. @JustinCappos, if you have feedback or concerns, we can make an new issue to update the template. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #80