Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup a Pull Request template to the site #97

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Setup a Pull Request template to the site #97

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4f5b01
Setup a Pull Request template to the site
shubhusion Oct 24, 2023
72a2192
Update .github/PULL_REQUEST_TEMPLATE.md
shubhusion Oct 24, 2023
bfd5518
Update .github/PULL_REQUEST_TEMPLATE.md
shubhusion Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@

# Summary of Changes

Describe the changes or improvements made in this pull request.

## Related Issue

Closes #<issue-number>

## Checklist

- [ ] I have read and followed the [project's contribution guidelines](https://github.com/secure-systems-lab/lab-guidelines/blob/master/dev-workflow.md), including code style and commit message conventions.
Copy link
Collaborator

@Abhijay007 Abhijay007 Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these contribution guidelines are not associated with uptane project

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The secure-systems-lab is out of the NYU team that leads Uptane. It may be more advantageous to copy the guidelines to our own site and link directly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abhijay007 I'm ok keeping the current text and flagging it for improvement later.

Copy link
Collaborator

@Abhijay007 Abhijay007 Oct 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya that works, we can create a separate issue for this

- [ ] My code is well-documented, and I've updated relevant documentation.
- [ ] I have added or updated test cases to ensure the code's functionality.
- [ ] I have tested these changes on my local environment.
- [ ] All tests pass, and there are no new linting errors.
- [ ] I have reviewed and proofread my code and the changes.
- [ ] The branch is up-to-date with the base branch.

## Screenshots (if applicable)

Attach any screenshots or images related to the changes.

## Additional Context

Add any additional context or information that might be helpful for reviewers.

## Reviewer(s)

@mention any specific reviewers or tag relevant team members.