Added UO-ResStock connection variable to the site properties schema #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7859262784
💛 - Coveralls |
| @@ -283,6 +283,18 @@ | |||
| "ev_curtailment_frac": { | |||
| "description": "Fraction between 0 and 1 that denotes curtailment of EV charging load to better align EV charging with expected energy production from a solar PV system", | |||
| "type": "number" | |||
| }, | |||
| "characterize_residential_buildings_from_buildstock_csv":{ | |||
There was a problem hiding this comment.
Why can't the existence of a populated resstock_buildstock_csv_path field serve as the boolean here?
| @@ -283,6 +283,18 @@ | |||
| "ev_curtailment_frac": { | |||
| "description": "Fraction between 0 and 1 that denotes curtailment of EV charging load to better align EV charging with expected energy production from a solar PV system", | |||
| "type": "number" | |||
| }, | |||
| "characterize_residential_buildings_from_buildstock_csv":{ | |||
| "description" : "Enable UO and ResStock connection to characterize residential buildings by matching them (and their properties) with building from the BuildStock CSV.", | |||
There was a problem hiding this comment.
For other residential -related field descriptions, we use "Optional for residential buildings" or "Required for residential buildings". For consistency, should we do something similar here?
| "description" : "Enable UO and ResStock connection to characterize residential buildings by matching them (and their properties) with building from the BuildStock CSV.", | ||
| "type": "boolean" | ||
| }, | ||
| "resstock_buildstock_csv_path":{ |
There was a problem hiding this comment.
I can't remember if we removed conditional requirements from the schema and replaced them with logic in the mapper, but do we somehow want to handle that? For example, if characterize_residential_buildings_from_buildstock_csv is true, then resstock_buildstock_csv_path must be populated.
8 tasks
kflemin
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #[issue number here]
Pull Request Description
Added UO restock connection inputs to the site schema