When you delete a post in dataview, the total number of posts is not updated

[Angamanga]

Problem
If I delete a post in dataview the total number of posts displayed on the top still remains the same (for example, before deleting: "20 of 20 posts". After deleting: "19 of 20 posts"

Reproduce the bug

1. Go to dataview, note how many posts are displayed in top of the list.
2. Delete one post
3. Note how many posts are displayed in the top of the list.

Implementation notes

• Fix in https://github.com/ushahidi/platform-client repo

• Hint 💡 The data-view files can be found here: https://github.com/ushahidi/platform-client/tree/develop/app/main/posts/views

• When you are done, 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

• 🏁 When done Ask in comments for a review :)

Want to work on this issue?🙋

Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

[sargamm]

Hey! I am Sargam, an outreachy applicant. I would like to go ahead with this issue. Thanks:)

[Angamanga]

@FabSar Please go ahead! Just comment here if you need guidance!

[sargamm]

hey! I was setting up the environment all this time. Since it's done now, Can you help me get started with the issue? Like where do i look for the code of the dataview section. Thanks!

[Angamanga]

@FabSar You find the all the post-view sections here: https://github.com/ushahidi/platform-client/tree/develop/app/main/posts/views and the data-view more specifically here: https://github.com/ushahidi/platform-client/blob/develop/app/main/posts/views/post-view-data.directive.js.

[sargamm]

okay thanks a lot!

[tharveypa]

@FabSar is this issue available, or are you still working? Thanks

[rowasc]

Hi. @FabSar is this issue available, or are you still working? let us know if you need some help.
Thanks!

[AlanaFarkas]

I cannot replicate this issue locally, has this been fixed?

[rowasc]

I was able to repro.
I had 21 posts, deleted one. Then the count is showing "19 of 21 posts" 🤔

[rowasc]

Slightly better image sequence, sorry:
2 of 2 posts (correct)

Deleted 1 (Count: 1 of 2. Incorrect) <- this is the error

Clicked data view again/reloaded (1 of 1 - correct again)

[AlanaFarkas]

Just opened a PR for this, here: ushahidi/platform-client#1365

[rohit645]

I am able to replicate this issue locally, @rowasc can i work on this issue?

[Angamanga]

@rohit645 Thank you for your interest in contributing, please go ahead and work on this and don't hesitate to reach out if you need further guidance!

[Angamanga]

@rohit645 How is it going, are you still working on this? Please let me know if you need any guidance!

[rohit645]

@Angamanga, I am trying to figure it out. I will be in touch shortly.

[Angamanga]

@Obadha2 Could you QA in Steve Buscemi?
Test-checklist:

1. Go to dataview, note how many posts are displayed in top of the list.
2. Delete one post

• Note how many posts are displayed in the top of the list, it should be the total posts minus 1

[AmTryingMyBest]

QA'd, passes. 👍