Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed total no of posts not updating on deleting a post fixes #3326 #1443

Merged
merged 4 commits into from
Mar 13, 2020

Conversation

rohit645
Copy link
Contributor

@rohit645 rohit645 commented Mar 5, 2020

This pull request makes the following changes:

  • Total number of posts are now getting updated.

Testing checklist:

  • passed eslint test.
  • I certify that I ran my checklist

Fixes ushahidi/platform#3326 .

@Angamanga Angamanga self-requested a review March 7, 2020 10:40
@Angamanga
Copy link
Collaborator

@rohit645 Thank you for your contribution! I will review shortly!

Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this! Its awesome! Just a super-small thing, I don't think the linter will let the commit through otherwise, could you remove the extra spaces i noted in the code?

@@ -40,7 +40,8 @@ function PostActionsDirective(
function activate() {
$scope.statuses = PostActionsService.getStatuses();
}


// Called when a single data item is deleted.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for figuring this out and clarifying it in the comments!

Copy link
Collaborator

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @rohit645

@Angamanga
Copy link
Collaborator

@Angamanga To merge to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When you delete a post in dataview, the total number of posts is not updated
2 participants