-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updating no of post after deleting a post and load-more button #1454
Conversation
Hey @individual-it, @rjmackay It looks like this brave person signed our Contributor License Agreement. 👍 Always at your service, clabot |
I'm leaving the commit history for now, just for reference. I can squash them when the responsible people are happy with the changes |
fixed conflicts that appeared because of #1443. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In one of the feature files there could be a scenario that first pages down into the middle of many posts, and then deletes a post.
And also page down to display all posts and delete the very last post (I guess that will need the "many posts" to have different titles so you can uniquely find the last post)
The issue is, that the order of posts is random |
@phil-davis I've addressed your requests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
hey @individual-it. Thanks for your contribution. As I see this, the change should not include a completely new testing framework to be included. I encourage you to use the testing setup that is already here. Thanks! |
@rowasc I've added the tests to make sure the fix does fix all cases for the user, specially because at the beginning there have been kind of two separate issues. |
This PR now only contains the fix, the UI tests are moved to #1473 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works fine! Thank you so much for your contribution 🎉
This pull request makes the following changes:
fixes updating the post counter when deleting a postUI end-to-end test infrastructure with tests for the fixes in this PRTesting checklist:
22 Scenarios about deleting posts and showing more posts, see .feature files in this PR. All tests are implemented in CI and are passing, see E2E test infrastructure #1473
I certify that I ran my checklist
Fixes ushahidi/platform#3861 &
ushahidi/platform#3326Ping @ushahidi/platform