Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move u128 implementation #234

Closed
kinggoesgaming opened this issue May 21, 2018 · 0 comments
Closed

Move u128 implementation #234

kinggoesgaming opened this issue May 21, 2018 · 0 comments
Milestone
0.6.4

Comments

@kinggoesgaming
Copy link
Member

Is your feature request related to a problem? Please describe.
No

Describe the solution you'd like
Implement u128 type support, with a u128 feature flag. Supported for users of 1.26.0 rust.

Is it blocking?
No.

Describe alternatives you've considered
breaking branch already has an implementation so we can wait for 0.7.0 release of uuid

Additional context
N/A

Other
#201
@kinggoesgaming kinggoesgaming added this to the 0.6.4 milestone May 21, 2018
@kinggoesgaming kinggoesgaming mentioned this issue May 21, 2018
Merged
4 tasks
bors bot added a commit that referenced this issue May 21, 2018
@bors @kinggoesgaming
Merge #238
7476812 
238: backport u128 support r=Dylan-DPC a=kinggoesgaming

**I'm submitting a ...**
  - [ ] bug fix
  - [x] feature enhancement
  - [ ] deprecation or removal
  - [ ] refactor

# Description
allow support for `u128` <-> `Uuid`

# Motivation
As of `1.26.0` rust you can use `u128` in stable rust

# Tests
added `test_from_u128` test function

# Related Issue(s)
#234 


Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.6.4
Development

No branches or pull requests
1 participant
@kinggoesgaming