support u128 #201
Merged
support u128 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
kinggoesgaming
requested review from
Dylan-DPC-zz,
KodrAus and
radix
as code owners
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Dylan-DPC-zz
approved these changes
Apr 23, 2018
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Apr 23, 2018
201: support u128 r=Dylan-DPC a=kinggoesgaming **I'm submitting a ...** - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [ ] refactor # Description * features introduced: `u128`, `nightly` * rust channel needed: `nightly` * dependency introduced: `byteorder` This introduced implementation for `u128` in the from of a `Uuid::from_u128` and `impl From` # Motivation `Uuid`s are 128 bits in size and rust natively provides a `u128` integer type. This # Tests `u128_support::test_from_u128()` introduced and passes # Related Issue(s) N/A Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
KodrAus
reviewed
Apr 23, 2018
| /// To create a [`Uuid`] from `u128`s, you need `u128` feature enabled for this crate. | ||
| /// | ||
| /// [`Uuid`]: ../struct.Uuid.html | ||
| #[inline(always)] |
There was a problem hiding this comment.
Usually inline(always) isn't ideal. A simple inline (without the always) would be better. Did you have a case where this method wasn't being inlined?
There was a problem hiding this comment.
actually that is a good point... I think I will remove in a future PR that does misc cleanup
LinusU
pushed a commit
to LinusU/uuid
that referenced
this pull request
Feb 26, 2020
* Fix buffer not being modified * Add unit tests for v5 buffer * Handle old node versions for test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a ...
Description
u128,nightlynightlybyteorderThis introduced implementation for
u128in the from of aUuid::from_u128andimpl FromMotivation
Uuids are 128 bits in size and rust natively provides au128integer type. ThisTests
u128_support::test_from_u128()introduced and passesRelated Issue(s)
N/A