Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discuss rename to from_slice #297

Closed
todo bot opened this issue Aug 14, 2018 · 0 comments · Fixed by #299
Closed

discuss rename to from_slice #297

todo bot opened this issue Aug 14, 2018 · 0 comments · Fixed by #299
Milestone
0.7.0

Comments

@todo
Copy link

todo bot commented Aug 14, 2018

uuid/src/lib.rs

Lines 207 to 212 in a262880

/// A Universally Unique Identifier (UUID).
#[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub struct Uuid(Bytes);
impl BytesError {

This issue was generated by todo based on a TODO comment in a262880 when #294 was merged. cc @uuid-rs.
@todo todo bot added the todo 🗒️ label Aug 14, 2018
@kinggoesgaming kinggoesgaming added this to the 0.7.0 milestone Aug 14, 2018
@kinggoesgaming kinggoesgaming mentioned this issue Aug 15, 2018
Merged
bors bot added a commit that referenced this issue Aug 17, 2018
@bors @kinggoesgaming
Merge #299
c29047d 
299: Uuid::{from_uuid_bytes, from_bytes} => Uuid::{from_bytes, from_slice} r=Dylan-DPC a=kinggoesgaming

**I'm submitting a(n)** refactor

# Description

These are just slight adjustments in names that I found were out of order.

# Motivation

Partially triggered by the recent decision to wipe the unnecessary `Uuid` prefix for every data structure

# Tests
Adjusted for current tests to pass

# Related Issue(s)
#294 

closes #297 

Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@bors bors bot closed this as completed in #299 Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Uuid::{from_uuid_bytes, from_bytes} => Uuid::{from_bytes, from_slice} uuid-rs/uuid
1 participant
@kinggoesgaming