Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove Uuid prefix #294

Merged
merged 5 commits into from
Aug 14, 2018
Merged

remove Uuid prefix #294

merged 5 commits into from
Aug 14, 2018

Conversation

kinggoesgaming
Copy link
Member

I'm submitting a(n) refactor

Description

It was discussed in the gitter chat that prefixing every data structure with Uuid is redundant.

@kinggoesgaming
remove Uuid prefix
cfaedf1 
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@todo
Copy link

todo bot commented Aug 13, 2018

discuss to_ vs as_ vs into_

uuid/src/adapter/mod.rs

Lines 73 to 78 in cfaedf1

// TODO: discuss to_ vs as_ vs into_
#[cfg(not(feature = "const_fn"))]
#[inline]
pub fn to_hyphenated(self) -> Hyphenated {
Hyphenated::from_uuid(self)
}

This comment was generated by todo based on a TODO comment in cfaedf1 in #294. cc @uuid-rs.

@todo
Copy link

todo bot commented Aug 13, 2018

discuss rename to `from_slice`

uuid/src/lib.rs

Lines 223 to 228 in cfaedf1

#[cfg(not(feature = "const_fn"))]
#[inline]
pub fn expected(&self) -> usize {
self.expected
}

This comment was generated by todo based on a TODO comment in cfaedf1 in #294. cc @uuid-rs.

@kinggoesgaming
fix doc tests
9fb9b9e 
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@todo
Copy link

todo bot commented Aug 13, 2018

discuss rename to `from_slice`

uuid/src/lib.rs

Lines 209 to 214 in 9fb9b9e

#[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub struct Uuid(Bytes);
impl BytesError {
/// The expected number of bytes.
#[cfg(feature = "const_fn")]

This comment was generated by todo based on a TODO comment in 9fb9b9e in #294. cc @uuid-rs.

@kinggoesgaming
fix the last doc test
b1107ce 
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@todo
Copy link

todo bot commented Aug 13, 2018

discuss rename to `from_slice`

uuid/src/lib.rs

Lines 209 to 214 in b1107ce

#[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub struct Uuid(Bytes);
impl BytesError {
/// The expected number of bytes.
#[cfg(feature = "const_fn")]

This comment was generated by todo based on a TODO comment in b1107ce in #294. cc @uuid-rs.

@kinggoesgaming
fix fmt
96ae325 
Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@todo
Copy link

todo bot commented Aug 14, 2018

discuss rename to `from_slice`

uuid/src/lib.rs

Lines 207 to 212 in 96ae325

/// A Universally Unique Identifier (UUID).
#[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub struct Uuid(Bytes);
impl BytesError {

This comment was generated by todo based on a TODO comment in 96ae325 in #294. cc @uuid-rs.

@kinggoesgaming kinggoesgaming added this to the 0.7.0 milestone Aug 14, 2018
@todo
Copy link

todo bot commented Aug 14, 2018

discuss rename to `from_slice`

uuid/src/lib.rs

Lines 207 to 212 in a262880

/// A Universally Unique Identifier (UUID).
#[derive(Clone, Copy, Debug, Eq, Hash, Ord, PartialEq, PartialOrd)]
pub struct Uuid(Bytes);
impl BytesError {

This comment was generated by todo based on a TODO comment in a262880 in #294. cc @uuid-rs.

@Dylan-DPC-zz
Copy link
Member

bors: r+

bors bot added a commit that referenced this pull request Aug 14, 2018
@bors @kinggoesgaming @Dylan-DPC
Merge #294
b57f88f 
294: remove Uuid prefix r=Dylan-DPC a=kinggoesgaming

**I'm submitting a(n)** refactor


# Description

It was discussed in the gitter chat that prefixing every data structure with `Uuid` is redundant.


Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
Co-authored-by: Dylan DPC <dylan.dpc@gmail.com>
@bors
Copy link
Contributor

bors bot commented Aug 14, 2018

Build succeeded

@bors bors bot merged commit a262880 into master Aug 14, 2018
This was referenced Aug 14, 2018
Closed
Closed
kinggoesgaming added a commit that referenced this pull request Aug 15, 2018
@kinggoesgaming
rename uuid::Uuid::from_uuid_bytes to uuid::Uuid::from_bytes
0fcc0f7 
This is inline with from_bytes to from_slice change AND with the uuid prefix
change in #294

Signed-off-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
@kinggoesgaming kinggoesgaming mentioned this pull request Aug 15, 2018
Merged
@kinggoesgaming kinggoesgaming deleted the no-prefix branch August 15, 2018 21:24
bors bot added a commit that referenced this pull request Aug 17, 2018
@bors @kinggoesgaming
Merge #299
c29047d 
299: Uuid::{from_uuid_bytes, from_bytes} => Uuid::{from_bytes, from_slice} r=Dylan-DPC a=kinggoesgaming

**I'm submitting a(n)** refactor

# Description

These are just slight adjustments in names that I found were out of order.

# Motivation

Partially triggered by the recent decision to wipe the unnecessary `Uuid` prefix for every data structure

# Tests
Adjusted for current tests to pass

# Related Issue(s)
#294 

closes #297 

Co-authored-by: Hunar Roop Kahlon <hunar.roop@gmail.com>
LinusU pushed a commit to LinusU/uuid that referenced this pull request Feb 26, 2020
@ctavan
Merge pull request uuid-rs#354 from uuidjs/remove-insecure-rng
55e895f 
Remove insecure builtin random number generator (RNG)

Closes uuid-rs#294 and fixes uuid-rs#173
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dylan-DPC-zz Dylan-DPC-zz Dylan-DPC-zz approved these changes

@KodrAus KodrAus Awaiting requested review from KodrAus

@radix radix Awaiting requested review from radix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kinggoesgaming @Dylan-DPC-zz @Dylan-DPC