Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kill: should fail if no PID is specified #6221

Closed
cakebaker opened this issue Apr 13, 2024 · 0 comments · Fixed by #6225
Closed

kill: should fail if no PID is specified #6221

cakebaker opened this issue Apr 13, 2024 · 0 comments · Fixed by #6225
Labels
good first issue For newcomers! U - kill

Comments

@cakebaker
Copy link
Contributor

When running GNU kill without a PID, it fails and shows an error message:

$ ~/projects/gnu/src/kill
/home/dho/projects/gnu/src/kill: no process ID specified
Try '/home/dho/projects/gnu/src/kill --help' for more information.
$ echo $?
1

uutils kill, on the other hand, doesn't fail and there is no output:

$ cargo run --features=unix kill
$ echo $?
0
jadijadi added a commit to jadijadi/coreutils that referenced this issue Apr 13, 2024
@jadijadi
kill: return 1 and gnu style stderr in case of no pid
5da5ffe 
closes uutils#6221
@jadijadi jadijadi mentioned this issue Apr 13, 2024
Merged
cakebaker pushed a commit that referenced this issue Apr 14, 2024
@jadijadi @BenWiederhake
kill: return 1 and gnu style stderr in case of no pid (#6225)
9b4a787 
* kill: return 1 and gnu style stderr in case of no pid

closes #6221

* Update src/uu/kill/src/kill.rs

Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>

---------

Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
sylvestre pushed a commit to sylvestre/coreutils that referenced this issue Apr 21, 2024
@jadijadi @BenWiederhake @sylvestre
kill: return 1 and gnu style stderr in case of no pid (uutils#6225)
620c526 
* kill: return 1 and gnu style stderr in case of no pid

closes uutils#6221

* Update src/uu/kill/src/kill.rs

Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>

---------

Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
sylvestre pushed a commit to sylvestre/coreutils that referenced this issue Apr 21, 2024
@jadijadi @BenWiederhake @sylvestre
kill: return 1 and gnu style stderr in case of no pid (uutils#6225)
0a724e1 
* kill: return 1 and gnu style stderr in case of no pid

closes uutils#6221

* Update src/uu/kill/src/kill.rs

Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>

---------

Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
sylvestre pushed a commit to sylvestre/coreutils that referenced this issue Apr 21, 2024
@jadijadi @BenWiederhake @sylvestre
kill: return 1 and gnu style stderr in case of no pid (uutils#6225)
51c4199 
* kill: return 1 and gnu style stderr in case of no pid

closes uutils#6221

* Update src/uu/kill/src/kill.rs

Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>

---------

Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue For newcomers! U - kill
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

kill: return 1 and gnu style stderr in case of no pid jadijadi/coreutils
1 participant
@cakebaker