kill: return 1 and gnu style stderr in case of no pid #6225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
GNU testsuite comparison: |
There was a problem hiding this comment.
Does exactly what is says on the tin. Thank you!
Can I ask you to change the excessive indentation?
(Also, sorry about the "review self-request", I fully expected it to be an error message, because self-requesting makes to sense to me, and I was curious how github handled that edge case.)
Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
|
GNU testsuite comparison: |
Thank you @BenWiederhake . Also applied your suggested change. |
|
Thanks! |
sylvestre
pushed a commit
to sylvestre/coreutils
that referenced
this pull request
Apr 21, 2024
* kill: return 1 and gnu style stderr in case of no pid closes uutils#6221 * Update src/uu/kill/src/kill.rs Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de> --------- Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
sylvestre
pushed a commit
to sylvestre/coreutils
that referenced
this pull request
Apr 21, 2024
* kill: return 1 and gnu style stderr in case of no pid closes uutils#6221 * Update src/uu/kill/src/kill.rs Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de> --------- Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
sylvestre
pushed a commit
to sylvestre/coreutils
that referenced
this pull request
Apr 21, 2024
* kill: return 1 and gnu style stderr in case of no pid closes uutils#6221 * Update src/uu/kill/src/kill.rs Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de> --------- Co-authored-by: Ben Wiederhake <BenWiederhake.GitHub@gmx.de>
|
@jadijadi thanks for sharing your experience here :) https://www.youtube.com/watch?v=wzWNkNPHJx0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
including a new test for "no pid provided" use case.
closes #6221