Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Forget Password to Landing Page #53

Merged
merged 4 commits into from
Nov 24, 2021
Merged

Moved Forget Password to Landing Page #53

merged 4 commits into from
Nov 24, 2021

Conversation

hujoseph99
Copy link
Contributor

Ticket link

Closes #28

Implementation description

  • Moved reset password button to login screen and removed it from our homepage
  • Removed auth check for resetPassword endpoint
  • Uses a user-inputted email as reset target

Steps to test

  1. Go to login page
  2. Click reset reset password
  3. Enter email to reset password (both valid emails and invalid)
  4. If valid, follow email prompts to reset password
  5. Return to login
  6. Try using the new password

What should reviewers focus on?

  • Nothing in particular - it's a rather simple ticket with a small number of changes

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

sherryhli
sherryhli previously approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@sherryhli sherryhli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left a comment with a minor suggestion but it's something that can be addressed once we have hi-fi designs

frontend/src/components/auth/ResetPassword.tsx
} catch (e) {
alert("invalid email");
}
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we clear the email state variable after attempting to reset?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that generally the email stays in the textbox if it's incorrect, an error message will just pop up to prompt the user to change it.

@hujoseph99 hujoseph99 merged commit 47347ca into main Nov 24, 2021
@hujoseph99 hujoseph99 deleted the add-forget-password branch November 24, 2021 03:17
This was referenced Dec 6, 2021
Merged
Merged
sherryhli pushed a commit that referenced this pull request Jan 6, 2022
@hujoseph99
Moved Forget Password to Landing Page (#53)
775a3b5 
* added functioniality for forgot password button

* added simple error check

* linter fixes

* added done reset password page, removed back to login button
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherryhli sherryhli sherryhli approved these changes

@daniel-sm-yu daniel-sm-yu Awaiting requested review from daniel-sm-yu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User login: move forget password to landing page
2 participants
@hujoseph99 @sherryhli