Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updates to accommodate EHR launch #17

Merged
merged 10 commits into from
Mar 9, 2023
Merged

Conversation

achen2401
Copy link

@achen2401 achen2401 commented Mar 3, 2023

address issue #16

UI will hide patient demographic info when need_patient_banner is detected as a launch context parameter when need_patient_banner is supplied in the querystring. Note, I am mindful of what Bill mentions about preserving branding, e.g. logo and app title, therefore the only part that is hidden is the patient demographic information - the header will still be displayed with logo and application title.

Some notes related to launching the app in SMIT launcher when I was testing
Example screenshot when launching app in SMIT simulated EHR iframe:
PatientSummaryInIframe
NOTE, the launch parameter, need_patient_banner, is automatically set to false when launched in SMIT simulated EHR iframe:
patientBannerNeeded

Example screenshot when launching app using SMIT launcher without the simulated EHR iframe:
PatientSummaryWithoutIFrame

In which case, need_patient_banner is automatically set to true:
NeedPatientBannerTrue

When launching the app in SMIT launcher, I noticed that I was not able to over-ride the patient_need_banner launch context parameter

@achen2401 achen2401 marked this pull request as ready for review March 7, 2023 19:47
Copy link
Member

@mcjustin mcjustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Amy

Reminding myself that need_patient_banner is a standard launch context parameter https://www.hl7.org/fhir/smart-app-launch/scopes-and-launch-context.html .

Also, you mention retaining branding but your screenshots don't include a logo - here's an example for posterity:
image

Copy link
Collaborator

@pbugni pbugni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you.

@mcjustin
Copy link
Member

mcjustin commented Mar 9, 2023

@pbugni @achen2401 Per our meeting today, in my testing just now Epic seems to be doing the right thing per the SoF standard "need_patient_banner" token param:
"true" - when launched from test harness via "External browser".
"false" - from test harness via "Embedded".

@achen2401 achen2401 merged commit 3cb4678 into main Mar 9, 2023
@achen2401 achen2401 deleted the feature/updates-for-ehr-launch branch March 9, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants