refactor: fix typescript code errors across code base and transform to ESM and TSX (part 1) #4133

sjschlapbach · 2024-05-29T19:54:17Z

Before merging, make sure that:

All dependent branches are merged into this branch
New introduced checks pass in the CI pipeline
A prisma migration for the remaining inconsistencies has been created
Immediately after merge test if push subscriptions still work as they should after the minor change to the subscription interface function

cypress · 2024-05-29T20:04:58Z

Test summary

38 • 0 • 0 • 0 • 1

Run details


Project	klicker-uzh
Status	Passed
Commit	`0ad9dd0` ℹ️
Started	Jul 30, 2024 8:58 PM
Ended	Jul 30, 2024 9:06 PM
Duration	07:11 💡
OS	Linux Ubuntu -
Browser	Electron 118

View run in Cypress Cloud ➡️

Flakiness

	cypress/e2e/G-microlearning-workflow.cy.ts		1
1	Different microlearning workflows > converts a seeded past microlearning into a practice quiz

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

coveralls · 2024-05-29T20:06:09Z

coverage: 68.493%. remained the same
when pulling 9e55705 on TypesChecking
into a78e485 on v3.

…iles (#4135)

…into PWATypes

… PWATypes

…Checking # Conflicts: # .github/workflows/cypress-testing.yml # apps/frontend-manage/src/components/sessions/cockpit/SessionBlock.tsx # apps/frontend-manage/src/components/sessions/creation/LiveSessionWizard.tsx # apps/frontend-pwa/src/components/surveys/SurveyPromotion.tsx # apps/func-incoming-responses/package.json # packages/graphql/src/ops.ts # packages/graphql/src/public/client.json # packages/graphql/src/public/server.json # packages/graphql/src/schema/session.ts # packages/i18n/messages/de.ts # packages/i18n/messages/en.ts # packages/shared-components/package.json # packages/shared-components/src/questions/KPAnswerOptions.tsx # packages/shared-components/src/questions/KPAnswerOptionsOLD.tsx # packages/shared-components/src/questions/MCAnswerOptions.tsx # packages/shared-components/src/questions/SCAnswerOptions.tsx # packages/shared-components/src/questions/SCAnswerOptionsOLD.tsx # pnpm-lock.yaml

coderabbitai · 2024-07-30T13:43:31Z

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

173 files out of 237 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2024-07-30T20:29:46Z

Quality Gate failed

Failed conditions
6 Security Hotspots

See analysis details on SonarCloud

cypress · 2024-07-30T21:37:59Z

Test summary

38 • 0 • 0 • 0 • 0

Run details


Project	klicker-uzh
Status	Passed
Commit	`5dd36e4`
Started	Jul 30, 2024 9:30 PM
Ended	Jul 30, 2024 9:37 PM
Duration	07:01 💡
OS	Linux Ubuntu -
Browser	Electron 118

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

sjschlapbach added 2 commits May 29, 2024 21:53

chore: add typescript checks to actions

cffec0a

chore: update github actions

5fac5fa

sjschlapbach and others added 26 commits May 29, 2024 22:09

chore: run type checks for all apps independent of individual fails

19baf2c

chore: build all required packages manually before running checks

aa67050

chore: build utils package

4f699bc

chore: fix build order

a7053c8

chore: fix build paths

c119f33

chore: move grading build

a72d84e

chore: update actions versions

2f8c408

chore: fix typescript types in frontend-pwa components

a4ad424

wip: fix almost all type errors on pwa pages

665d460

chore: fix type errors in shared components

4029b5f

chore: fix type errors for frontend-control

81f92cf

wip: fix type errors in frontend manage

bd79f19

wip: fix types on live session evaluation view

a6e885e

wip: continue eliminating type errors from frontend-manage

b144282

chore: fix type issues in shared components package

d138b07

chore: update github actions

42e65d4

chore: extend type check

a3a1837

chore: extend type check to utils package

1c2bc14

chore: fix type errors in prisma package

f041a56

chore: start fixing types in graphql service

52ace64

refactor: move all packages to ESM, upgrade TypeScript and tsconfig f…

4f50add

…iles (#4135)

Merge branch 'TypesChecking' of https://github.com/uzh-bf/klicker-uzh …

865aad5

…into PWATypes

fix type issues on leaderboard entry

2a9d231

chore: fix missing student course

a7d2fbb

more fixes

e02ec28

Merge branch 'PWATypes' of https://github.com/uzh-bf/klicker-uzh into…

a8d20be

… PWATypes

sjschlapbach and others added 13 commits May 30, 2024 20:49

chore: add lib skip to office-addin config

abb6559

chore: simplify type check action

4bbb1b7

tsc no emit

a4be17f

Merge branch 'PWATypes' of https://github.com/uzh-bf/klicker-uzh into…

26df715

… PWATypes

enhance: replace outdated md5 module through node crypto implementation

def49eb

Merge branch 'PWATypes' of https://github.com/uzh-bf/klicker-uzh into…

26ecbd6

… PWATypes

memoized validation schema on edit form

03736ea

Merge branch 'PWATypes' of https://github.com/uzh-bf/klicker-uzh into…

54a6cb7

… PWATypes

chore: fix types in backend

995d9c7

chore: fix push subscription types in frontend-pwa (#4136)

7f64f45

Merge branch 'v3' into TypesChecking

647f6b9

Merge branch 'TypesChecking' into PWATypes

80589b4

chore: fix typescript types in frontends and shared components (#4134)

fcb112d

rschlaefli changed the title ~~enhance: fix typescript code errors across code base~~ refactor: fix typescript code errors across code base and transform to ESM (part 1) Jul 30, 2024

migrate to tsx

2fb9afb

rschlaefli changed the title ~~refactor: fix typescript code errors across code base and transform to ESM (part 1)~~ refactor: fix typescript code errors across code base and transform to ESM and TSX (part 1) Jul 30, 2024

rschlaefli added 4 commits July 30, 2024 21:51

chore: fix formatting

e63ed1f

ci: fix auth workflow for typechecking

983b710

fix some type issues

df05b41

fix: module and import in jest for grading test

9e55705

rschlaefli approved these changes Jul 30, 2024

View reviewed changes

rschlaefli enabled auto-merge July 30, 2024 20:27

rschlaefli added this pull request to the merge queue Jul 30, 2024

rschlaefli removed this pull request from the merge queue due to a manual request Jul 30, 2024

rschlaefli merged commit 5dd36e4 into v3 Jul 30, 2024
14 of 18 checks passed

rschlaefli deleted the TypesChecking branch July 30, 2024 21:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: fix typescript code errors across code base and transform to ESM and TSX (part 1) #4133

refactor: fix typescript code errors across code base and transform to ESM and TSX (part 1) #4133

sjschlapbach commented May 29, 2024 •

edited

Loading

cypress bot commented May 29, 2024 •

edited

Loading

coveralls commented May 29, 2024 •

edited

Loading

coderabbitai bot commented Jul 30, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

sonarqubecloud bot commented Jul 30, 2024

cypress bot commented Jul 30, 2024

refactor: fix typescript code errors across code base and transform to ESM and TSX (part 1) #4133

refactor: fix typescript code errors across code base and transform to ESM and TSX (part 1) #4133

Conversation

sjschlapbach commented May 29, 2024 • edited Loading

cypress bot commented May 29, 2024 • edited Loading

Test summary

Run details

Flakiness

coveralls commented May 29, 2024 • edited Loading

coderabbitai bot commented Jul 30, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

sonarqubecloud bot commented Jul 30, 2024

Quality Gate failed

cypress bot commented Jul 30, 2024

Test summary

Run details

sjschlapbach commented May 29, 2024 •

edited

Loading

cypress bot commented May 29, 2024 •

edited

Loading

coveralls commented May 29, 2024 •

edited

Loading

coderabbitai bot commented Jul 30, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)