refactor: fix typescript code errors across code base and transform to ESM and TSX (part 1)

.github/workflows/check-types.yml

@@ -0,0 +1,134 @@
+name: Check typescript types
+
+on:
+  push:
+    branches: ['v3', 'v3*']
+  pull_request:
+    # branches: ["v3", "v3*"]
+    types: [opened, synchronize, reopened]
+
+env:
+  TURBO_TOKEN: ${{ secrets.TURBO_TOKEN }}
+  TURBO_TEAM: ${{ secrets.TURBO_TEAM }}
+  TURBO_REMOTE_ONLY: true
+
+jobs:
+  check:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
+        with:
+          version: 8.15.8
+          run_install: true
+      - name: Build all required packages
+        run: |
+          cd packages/prisma
+          pnpm run build
+          cd ../util
+          pnpm run build
+          cd ../grading
+          pnpm run build
+          cd ../graphql
+          pnpm run build
+          cd ../markdown
+          pnpm run build
+          cd ../shared-components
+          pnpm run build
+
+      - name: Check prisma package typescript types
+        shell: bash
+        run: |
+          cd packages/prisma
+          pnpm run check
+      - name: Check grading package typescript types
+        if: always() # Run this step even if the previous one fails
+        shell: bash
+        run: |
+          cd packages/grading
+          pnpm run check
+      - name: Check util package typescript types
+        if: always() # Run this step even if the previous one fails
+        shell: bash
+        run: |
+          cd packages/util
+          pnpm run check
+      - name: Check graphql package typescript types
+        if: always() # Run this step even if the previous one fails
+        shell: bash
+        run: |
+          cd packages/graphql
+          pnpm run check
+      - name: Check lti package typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd packages/lti
+          pnpm run check
+      - name: Check shared-components package typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd packages/shared-components
+          pnpm run check
+      - name: Check v2 export function typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/func-migration-v2-export
+          pnpm run check
+      - name: Check v3 import function typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/func-migration-v3-import
+          pnpm run check
+      - name: Check backend-docker typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/backend-docker
+          pnpm run check
+      - name: Check frontend-pwa typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/frontend-pwa
+          pnpm run check
+      - name: Check frontend-manage typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/frontend-manage
+          pnpm run check
+      - name: Check frontend-control typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/frontend-control
+          pnpm run check
+      - name: Check frontend-auth typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/auth
+          pnpm run check
+      - name: Check office-addin typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/office-addin
+          pnpm run check
+      - name: Check func-response-processor typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/func-response-processor
+          pnpm run check
+      - name: Check func-incoming-responses typescript types
+        if: always()
+        shell: bash
+        run: |
+          cd apps/func-incoming-responses
+          pnpm run check

.github/workflows/cypress-testing.yml

@@ -1,7 +1,7 @@
 name: Klicker automated testing with cypress
 on:
   push:
-    branches: ["v3", "v3*"]
+    branches: ['v3', 'v3*']
   pull_request:
     types: [opened, synchronize, reopened]
   # workflow_dispatch:
@@ -62,7 +62,7 @@ jobs:
 
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
           run_install: false
 
       - name: Get pnpm store directory
@@ -129,7 +129,7 @@ jobs:
         timeout-minutes: 20
         with:
           install: false
-          wait-on: "http://127.0.0.1:3000/api/graphql, http://127.0.0.1:3001, http://127.0.0.1:3002, http://127.0.0.1:3003, http://127.0.0.1:3010"
+          wait-on: 'http://127.0.0.1:3000/api/graphql, http://127.0.0.1:3001, http://127.0.0.1:3002, http://127.0.0.1:3003, http://127.0.0.1:3010'
           wait-on-timeout: 300
           record: true
           browser: electron

.github/workflows/format-and-lint.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v3
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
           run_install: true
       - name: Check formatting
         shell: bash
@@ -33,7 +33,7 @@ jobs:
         uses: actions/checkout@v3
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
           run_install: true
       - name: Check linting
         shell: bash
@@ -46,7 +46,7 @@ jobs:
   #       uses: actions/checkout@v3
   #     - uses: pnpm/action-setup@v2
   #       with:
-  #         version: 8.14.1
+  #         version: 8.15.8
   #         run_install: true
   #     - name: Check types
   #       shell: bash

.github/workflows/test-grading.yml

@@ -18,7 +18,7 @@ jobs:
         uses: actions/checkout@v3
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
           run_install: true
       - name: Test functions
         shell: bash

.github/workflows/v3_klickeruzhprod-migration-export.yml

@@ -27,7 +27,7 @@ jobs:
 
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
 
       - name: 'Resolve Project Dependencies Using Npm'
         shell: bash

.github/workflows/v3_klickeruzhprod-migration-import.yml

@@ -28,7 +28,7 @@ jobs:
 
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
 
       - name: 'Resolve Project Dependencies Using Npm'
         shell: bash

.github/workflows/v3_klickeruzhprod-response-processor(qa).yml

@@ -29,7 +29,7 @@ jobs:
 
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
 
       - name: 'Resolve Project Dependencies Using Npm'
         shell: bash

.github/workflows/v3_klickeruzhprod-response-processor.yml

@@ -23,7 +23,7 @@ jobs:
 
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
 
       - name: 'Resolve Project Dependencies Using Npm'
         shell: bash

.github/workflows/v3_klickeruzhprod-responses(qa).yml

@@ -29,7 +29,7 @@ jobs:
 
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
 
       - name: 'Resolve Project Dependencies Using Npm'
         shell: bash

.github/workflows/v3_klickeruzhprod-responses.yml

@@ -23,7 +23,7 @@ jobs:
 
       - uses: pnpm/action-setup@v2
         with:
-          version: 8.14.1
+          version: 8.15.8
 
       - name: 'Resolve Project Dependencies Using Npm'
         shell: bash

.prettierrc.js

@@ -0,0 +1,5 @@
+module.exports = {
+  semi: false,
+  singleQuote: true,
+  trailingComma: 'es5',
+}

.tool-versions

@@ -1,2 +1,2 @@
 node 20.11.0
-pnpm 8.14.1
+pnpm 8.15.8

apps/auth/Dockerfile

@@ -9,7 +9,7 @@ WORKDIR /app
 RUN apk add --no-cache libc6-compat
 RUN apk update
 
-RUN npm i -g --ignore-scripts pnpm@8.14.1 turbo@1.11.3
+RUN npm i -g --ignore-scripts pnpm@8.15.8 turbo@1.13.3
 
 COPY . .
 
@@ -22,7 +22,7 @@ WORKDIR /app
 RUN apk add --no-cache libc6-compat
 RUN apk update
 
-RUN npm i -g --ignore-scripts pnpm@8.14.1 turbo@1.11.3
+RUN npm i -g --ignore-scripts pnpm@8.15.8 turbo@1.13.3
 
 COPY --from=builder /app/out/json/ .
 COPY --from=builder /app/out/pnpm* .

apps/auth/package.json

@@ -27,7 +27,7 @@
     "@types/bcryptjs": "^2.4.2",
     "@types/js-cookie": "^3.0.3",
     "@types/jsonwebtoken": "^9.0.2",
-    "@types/node": "^18.17.4",
+    "@types/node": "^20.12.12",
     "@types/react": "^18.2.18",
     "@types/react-dom": "^18.2.7",
     "autoprefixer": "10.4.14",
@@ -42,11 +42,12 @@
     "prettier-plugin-tailwindcss": "0.4.1",
     "prisma": "5.9.1",
     "tailwindcss": "3.3.3",
-    "typescript": "5.0.4"
+    "typescript": "5.4.5"
   },
   "scripts": {
     "build": "next build",
     "build:test": "cross-env NODE_ENV=test next build",
+    "check": "tsc --noEmit",
     "dev": "next dev --port 3010",
     "dev:offline": "next dev --port 3010",
     "dev:test": "cross-env NODE_ENV=test next dev --port 3010",

apps/auth/src/pages/api/auth/[...nextauth].ts

@@ -13,11 +13,21 @@ import prisma from 'src/lib/prisma'
 
 export const COOKIE_NAME = 'next-auth.session-token'
 
-interface ExtendedProfile extends Profile {
+export interface ExtendedProfile extends Profile {
   swissEduPersonUniqueID: string
   swissEduIDLinkedAffiliation?: string[]
 }
 
+export interface ExtendedUser {
+  id: string
+  email: string
+  role: UserRole
+  shortname: string
+  scope: string
+  catalystInstitutional: boolean
+  catalystIndividual: boolean
+}
+
 function reduceCatalyst(acc: boolean, affiliation: string) {
   try {
     if (
@@ -207,12 +217,13 @@ export const authOptions: NextAuthOptions = {
 
   callbacks: {
     async signIn({ user, account, profile, email }) {
-      if (profile?.sub && account?.provider) {
+      const profileData = profile as ExtendedProfile
+      if (profileData?.sub && account?.provider) {
         const userAccount = await prisma.account.findUnique({
           where: {
             provider_providerAccountId: {
               provider: account.provider,
-              providerAccountId: profile.sub,
+              providerAccountId: profileData.sub,
             },
           },
         })
@@ -221,11 +232,11 @@ export const authOptions: NextAuthOptions = {
           const user = await prisma.user.update({
             where: { id: userAccount.userId },
             data: {
-              email: profile.email,
+              email: profileData.email,
               lastLoginAt: new Date(),
               catalystInstitutional:
-                (profile.email?.endsWith('uzh.ch') ||
-                  profile.swissEduIDLinkedAffiliation?.reduce<boolean>(
+                (profileData.email?.endsWith('uzh.ch') ||
+                  profileData.swissEduIDLinkedAffiliation?.reduce<boolean>(
                     reduceCatalyst,
                     false
                   )) ??
@@ -246,17 +257,20 @@ export const authOptions: NextAuthOptions = {
     },
 
     async jwt({ token, user, account, profile, trigger }) {
+      const profileData = profile as ExtendedProfile
+      const userData = user as ExtendedUser
+
       if (typeof user !== 'undefined') {
-        token.shortname = user.shortname
+        token.shortname = userData.shortname
 
-        if (typeof profile?.swissEduPersonUniqueID === 'string') {
+        if (typeof profileData?.swissEduPersonUniqueID === 'string') {
           token.scope = UserLoginScope.ACCOUNT_OWNER
         } else {
           token.scope = (user as any).scope as UserLoginScope
         }
 
-        token.catalystInstitutional = user.catalystInstitutional
-        token.catalystIndividual = user.catalystIndividual
+        token.catalystInstitutional = userData.catalystInstitutional
+        token.catalystIndividual = userData.catalystIndividual
 
         token.role = UserRole.USER
       }

apps/auth/src/pages/api/discourse.ts

@@ -45,9 +45,9 @@ export default async function handler(
   const nonce = ssoURL.searchParams.get('nonce')
   const redirectURL = ssoURL.searchParams.get('return_sso_url')
 
-  const userEmail = session.email
+  const userEmail = session.email!
   const userId = session.sub
-  const userShortname = session.shortname
+  const userShortname = session.shortname as string
   const userRole = session.role
 
   let payload = `nonce=${nonce}&email=${encodeURIComponent(