enhance: implement more detailed deletion confirmation modal for group activities

[sjschlapbach]

Summary by CodeRabbit

Release Notes

• New Features

  • Introduced a new modal for confirming the deletion of group activities, enhancing user experience.
  • Added a new GraphQL query to retrieve summaries of group activities, including the number of started instances and submissions.

• Bug Fixes

  • Updated end-to-end tests to improve accuracy and coverage for group activity workflows.

• Documentation

  • Enhanced localization strings for both German and English to improve user guidance and feedback.

• Chores

  • Refactored existing components to streamline deletion processes and improve code maintainability.

[aviator-app]

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

---

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

📝 Walkthrough

Walkthrough

The pull request introduces significant changes to the management of group activity deletions within the application. It removes the existing deletion mutation and replaces it with a new modal component, GroupActivityDeletionModal, which handles deletion confirmations. Additionally, a new GraphQL query for retrieving group activity summaries is added, along with corresponding updates to various files, including localization strings and testing scripts to accommodate the new functionality.

Changes

File	Change Summary
apps/frontend-manage/src/components/courses/GroupActivityElement.tsx	Removed DeleteGroupActivityDocument mutation and associated logic; integrated GroupActivityDeletionModal with updated props.
apps/frontend-manage/src/components/courses/modals/ActivityDeletionModal.tsx	Added deleteGroupActivity mutation and deletingGroupActivity variable; updated button logic for deletion handling.
apps/frontend-manage/src/components/courses/modals/GroupActivityDeletionModal.tsx	Introduced new component to manage group activity deletions; includes fetching logic and confirmation state tracking.
cypress/cypress/e2e/K-group-activity-workflow.cy.ts	Added new test cases, updated selectors, refined deletion process checks, and enhanced validation for editing activities.
packages/graphql/src/graphql/ops/QGetGroupActivitySummary.graphql	Added new GraphQL query GetGroupActivitySummary to retrieve group activity metrics.
packages/graphql/src/ops.schema.json	Introduced new fields numOfStartedInstances and numOfSubmissions in GroupActivitySummary.
packages/graphql/src/ops.ts	Updated type definitions for various GraphQL entities, including new fields for group activity summaries.
packages/graphql/src/public/client.json	Added new entry for GetGroupActivitySummary in the client JSON file.
packages/graphql/src/public/schema.graphql	Added new type definition for GroupActivitySummary and updated the Query type with getGroupActivitySummary.
packages/graphql/src/public/server.json	Introduced new query GetGroupActivitySummary for retrieving group activity performance metrics.
packages/graphql/src/schema/groupActivity.ts	Added new interface IGroupActivitySummary and its implementation in the schema.
packages/graphql/src/schema/query.ts	Added getGroupActivitySummary method in the Query object; updated import statements.
packages/graphql/src/services/groups.ts	Introduced getGroupActivitySummary function to retrieve activity summary based on ID; modified existing functions for improved mapping.
packages/i18n/messages/de.ts	Extensive modifications to German localization strings, adding new keys and updating existing ones across various sections.
packages/i18n/messages/en.ts	Extensive modifications to English localization strings, adding new keys and refining existing ones for clarity and consistency.

Possibly related PRs

• feat: add possibility to delete courses #4282: The changes in this PR involve the introduction of a modal for deleting courses, which aligns with the main PR's focus on managing deletion functionalities through modals.
• feat: allow deletion of all activities independent of status and distinguish between hard and soft deletion in backend #4294: This PR enhances deletion functionalities for various activities, including group activities, which is directly related to the main PR's updates to the deletion process in the GroupActivityElement component.
• enhance: implement more detailed deletion confirmation modal for group activities #4298: This PR implements a detailed deletion confirmation modal for group activities, which is closely related to the main PR's introduction of the GroupActivityDeletionModal for managing deletions.

Suggested reviewers

• rschlaefli

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[cypress]

klicker-uzh    Run #3160

Run Properties:   Passed #3160  •  2b541a2fb6 ℹ️: Merge db2d0789ed3de7ae7606ea68430a589ad0f5e0cf into 9000311196089681346e822e5543...

Project	klicker-uzh
Branch Review	group-activity-deletion-modal
Run status	Passed #3160
Run duration	09m 38s
Commit	2b541a2fb6 ℹ️: Merge db2d0789ed3de7ae7606ea68430a589ad0f5e0cf into 9000311196089681346e822e5543...
Committer	Julius Schlapbach
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	47
View all changes introduced in this branch ↗︎

[sonarqubecloud]

Quality Gate failed

Failed conditions
6.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

[cypress]

klicker-uzh    Run #3161

Run Properties:   Passed #3161  •  64758767a6: enhance: implement more detailed deletion confirmation modal for group activitie...

Project	klicker-uzh
Branch Review	v3
Run status	Passed #3161
Run duration	10m 28s
Commit	64758767a6: enhance: implement more detailed deletion confirmation modal for group activitie...
Committer	Julius Schlapbach
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	2
Pending	0
Skipped	0
Passing	47
View all changes introduced in this branch ↗︎