feat: add possibility to start group activity synchronously before scheduled start date #4306

sjschlapbach · 2024-10-15T12:03:33Z

This pull requests adds the possibility to start a group activity through a corresponding action on the course overview. A connected subscription ensures that the activity immediately appears on the student's devices and allows them to solve it. With this additional feature, the core functionalities required for synchronous group activities are now available.

Summary by CodeRabbit

Release Notes

New Features
- Introduced a new modal for starting group activities, enhancing user interaction.
- Added new GraphQL queries and mutations for improved management of group activities.
User Interface Adjustments
- Updated icon sizes for consistency across course management components.
Localization Updates
- Enhanced localization with new keys for group activity notifications and improved clarity in existing messages.
Course Data Enhancements
- Improved course data retrieval, including participant group counts for better insights on courses.

…view immediately after group activity start

aviator-app · 2024-10-15T12:03:38Z

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.

See the real-time status of this PR on the Aviator webapp.

Use the Aviator Chrome Extension to see the status of your PR within GitHub.

cypress · 2024-10-15T12:20:50Z

klicker-uzh Run #3214

Run Properties: Passed #3214 • 04bb02d796 ℹ️: Merge 75eec421f107390c5a89a914ba8276db29ec1874 into dd00908932eb6dc18201d9811636...

Project	`klicker-uzh`
Run status	`Passed #3214`
Run duration	`10m 25s`
Commit	`04bb02d796 ℹ️: Merge 75eec421f107390c5a89a914ba8276db29ec1874 into dd00908932eb6dc18201d9811636...`
Committer	`Julius Schlapbach`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`111`

…for group activity loading

sjschlapbach · 2024-10-15T16:14:13Z

apps/frontend-pwa/src/components/groupActivity/GroupActivityListSubscriber.tsx

+      ): { groupActivities: GroupActivity[] } => {
+        if (!subscriptionData.data) return prev
+
+        // required saveguard since the subscription is somehow triggered twice


@rschlaefli Do you have an idea why this submission is triggered twice? The useEffect and the backend mutation are only executed once, the subscription in the backend is only triggered once, however, the subscription here is executed twice...

…ogic

coderabbitai · 2024-10-15T18:34:51Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request introduces multiple updates across various packages, primarily focusing on enhancing group activity functionalities, updating dependency versions, adjusting user interface elements, and improving localization. Key changes include the addition of new components and GraphQL operations related to group activities, modifications to existing components for better data management, and updates to localization files to provide clearer user messages. Additionally, there are UI adjustments to ensure consistency in icon sizes.

Changes

Files Affected	Change Summary
`apps/backend-docker/package.json`, `apps/frontend-control/package.json`, `apps/frontend-manage/package.json`, `apps/frontend-pwa/package.json`, `packages/graphql/package.json`	Updated dependency versions: `graphql` from `16.7.1` to `16.9.0`; `@apollo/client` from `3.8.3` to `3.11.8` in frontend packages; `graphql-codegen-persisted-query-ids` from `0.1.2` to `0.2.0` in frontend packages.
`apps/frontend-manage/src/components/courses/GroupActivityElement.tsx`, `apps/frontend-manage/src/components/courses/GroupActivityList.tsx`, `apps/frontend-manage/src/components/courses/modals/GroupActivityStartingModal.tsx`, `apps/frontend-pwa/src/components/course/SuspendedGroupView.tsx`, `apps/frontend-pwa/src/components/groupActivity/GroupActivityListSubscriber.tsx`, `apps/frontend-pwa/src/pages/course/[courseId]/index.tsx`, `packages/graphql/src/graphql/ops/MOpenGroupActivity.graphql`, `packages/graphql/src/graphql/ops/QGetCourseGroupActivities.graphql`, `packages/graphql/src/graphql/ops/QGetGroupActivityInstances.graphql`, `packages/graphql/src/graphql/ops/SGroupActivityStarted.graphql`, `packages/graphql/src/schema/mutation.ts`, `packages/graphql/src/schema/query.ts`, `packages/graphql/src/schema/subscription.ts`, `packages/graphql/src/services/groups.ts`	Enhanced group activity functionalities including the addition of `GroupActivityStartingModal`, updates to existing components to accept new props, and modifications to GraphQL schema and services for better group activity management.
`apps/frontend-manage/src/components/courses/PracticeQuizElement.tsx`, `apps/frontend-manage/src/components/courses/actions/PublishGroupActivityButton.tsx`, `apps/frontend-manage/src/components/courses/actions/PublishMicroLearningButton.tsx`, `apps/frontend-manage/src/components/courses/actions/PublishPracticeQuizButton.tsx`, `apps/frontend-manage/src/components/courses/actions/UnpublishMicroLearningButton.tsx`, `apps/frontend-manage/src/components/courses/groupActivity/GroupActivityExtensionButton.tsx`, `apps/frontend-manage/src/components/courses/groupActivity/GroupActivityGradingLink.tsx`, `apps/frontend-manage/src/components/courses/groupActivity/GroupActivityUnpublishButton.tsx`	Adjusted user interface elements by increasing FontAwesome icon sizes from `1.1rem` to `1.2rem` for consistency across components.
`packages/i18n/messages/de.ts`, `packages/i18n/messages/en.ts`	Updated localization messages with new keys for group activity notifications and modifications for clarity and dynamic content in existing keys.
`apps/frontend-pwa/src/pages/course/[courseId]/index.tsx`, `packages/graphql/src/schema/course.ts`, `packages/graphql/src/schema/query.ts`, `packages/graphql/src/services/courses.ts`	Enhanced course data management by modifying the `CourseOverview` component to use new queries, adding `numOfParticipantGroups` field to GraphQL schema, and updating service methods to improve data retrieval for courses.

Possibly related PRs

enhance(apps/frontend-manage): limit group activity creation to courses where group creation is enabled #4259: Enhances the group activity creation process by limiting it to courses where group creation is enabled.
fix: ensure that participant group names cannot be empty #4280: Ensures participant group names cannot be empty, relevant to group activity management.
feat: add possibility to delete courses #4282: Adds the ability to delete courses, relating to the management of group activities.
feat: add possibility to extend microlearnings and group activities before end date #4283: Introduces the ability to extend microlearnings and group activities, directly connecting to enhancements in group activity functionalities.
feat: allow deletion of all activities independent of status and distinguish between hard and soft deletion in backend #4294: Allows deletion of all activities independent of status, relevant to group activity management.
enhance: implement more detailed deletion confirmation modal for group activities #4298: Implements a more detailed deletion confirmation modal for group activities, aligning with management changes in the main PR.
feat: add possibility to end group activity manually and introduce additional ended status #4303: Adds the ability to end group activities manually, directly related to functionalities in the main PR.
enhance: resolve seed-dependency of group activity through extended test suite #4305: Resolves seed-dependency issues for group activities, enhancing the testing framework related to changes in the main PR.

Suggested reviewers

rschlaefli

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

sonarqubecloud · 2024-10-15T18:42:26Z

Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarCloud

cypress · 2024-10-15T19:32:23Z

klicker-uzh Run #3215

Run Properties: Passed #3215 • 3e9b53e93d: feat: add possibility to start group activity synchronously before scheduled sta...

Project	`klicker-uzh`
Run status	`Passed #3215`
Run duration	`10m 36s`
Commit	`3e9b53e93d: feat: add possibility to start group activity synchronously before scheduled sta...`
Committer	`Julius Schlapbach`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`111`

sjschlapbach added 2 commits October 15, 2024 12:32

wip: allow to trigger start of group activity immediately

8dc1d5c

wip: implement working subscription to show status update on student …

3b5a851

…view immediately after group activity start

fix: ensure that subscriptions all work as required and use suspense …

4c60792

…for group activity loading

sjschlapbach commented Oct 15, 2024

View reviewed changes

enhance(cypress): extend test suite with synchronous group activity l…

fd24245

…ogic

sjschlapbach marked this pull request as ready for review October 15, 2024 18:34

chore: rename component

75eec42

sjschlapbach requested a review from rschlaefli October 15, 2024 19:13

sjschlapbach merged commit 3e9b53e into v3 Oct 15, 2024
14 of 16 checks passed

sjschlapbach deleted the group-activity-immediate-start branch October 15, 2024 19:13

coderabbitai bot mentioned this pull request Oct 30, 2024

enhance: define new element blocks for improved live quiz data structure #4342

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add possibility to start group activity synchronously before scheduled start date #4306

feat: add possibility to start group activity synchronously before scheduled start date #4306

sjschlapbach commented Oct 15, 2024 •

edited by coderabbitai bot

Loading

aviator-app bot commented Oct 15, 2024 •

edited

Loading

cypress bot commented Oct 15, 2024 •

edited

Loading

sjschlapbach Oct 15, 2024

coderabbitai bot commented Oct 15, 2024 •

edited

Loading

Review failed

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

sonarqubecloud bot commented Oct 15, 2024

cypress bot commented Oct 15, 2024

feat: add possibility to start group activity synchronously before scheduled start date #4306

feat: add possibility to start group activity synchronously before scheduled start date #4306

Conversation

sjschlapbach commented Oct 15, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

Release Notes

aviator-app bot commented Oct 15, 2024 • edited Loading

Current Aviator status

cypress bot commented Oct 15, 2024 • edited Loading

klicker-uzh Run #3214

sjschlapbach Oct 15, 2024

Choose a reason for hiding this comment

coderabbitai bot commented Oct 15, 2024 • edited Loading

Review failed

Walkthrough

Changes

Possibly related PRs

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

sonarqubecloud bot commented Oct 15, 2024

Quality Gate passed

cypress bot commented Oct 15, 2024

klicker-uzh Run #3215

sjschlapbach commented Oct 15, 2024 •

edited by coderabbitai bot

Loading

aviator-app bot commented Oct 15, 2024 •

edited

Loading

cypress bot commented Oct 15, 2024 •

edited

Loading

coderabbitai bot commented Oct 15, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)