Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: hidden attribute is set to false when server instantiates the component #3334

Closed
manolo opened this issue Jan 16, 2018 · 3 comments
Assignees
Milestone

Comments

@manolo
Copy link
Member

manolo commented Jan 16, 2018

Having this code, the button is finally shown (hidden attribute is removed)

<vaadin-button id="foo" hidden>Foo</vaadin-button>

@Id("foo")
private Button foo;

manolo added a commit to vaadin/bakery-app-starter-flow-spring that referenced this issue Jan 16, 2018
@pleku pleku added the bug label Jan 17, 2018
manolo added a commit to vaadin/bakery-app-starter-flow-spring that referenced this issue Jan 17, 2018
manolo added a commit to vaadin/bakery-app-starter-flow-spring that referenced this issue Jan 17, 2018
* Bump vaadin and spring-boot versions

* Update to platform version 10.0.0.alpha11

* Bump version to alpha12

Changed BeforeNavigationObserver to BeforeEnterEvent

BFF-493

* Depend on flow-1.0.0.alpha17 which has the fix for #3264.

  Flow has removed `body {height: 100%}`, using `@BodySize`
  vaadin/flow@3a719095

  Rebasing master.

Jira: BFF-493

* Add flow-grid-component-renderer.html to workaround for production bundle

* Merged and resolved conflicts

* Depend on charts-11 until vaadin-13 is out. Remove temporary workarounds

* ignore flow-grid-component-renderer in linter

* Depend on vaadin 10.0.0.alpha13, remove workarounds in pom

* Making tests pass

* Vaadin tabs needs `outline: none`

* Workaround for regression on `hidden` elements

  Flow issue: vaadin/flow#3334

* The waitFor workaround is not needed with testbench 6.0.0.alpha4

* Update testbench version

* Removed FIXME comment
@ZheSun88
Copy link
Contributor

a short investigation with platform 10.0.0.alpha14.

the hidden attribute can be only set via using button.setVisible(true/false) api, but if we set the attribute from the template file with <vaadin-button id="foo" hidden>Foo</vaadin-button> or <vaadin-button id="foo" hidden="true">Foo</vaadin-button>, the attribute will be removed, when server instantiates the component.

for setting other attribute from template file, it works as expected. (tested with disabled).

@denis-anisimov
Copy link
Contributor

Why does it remove the attribute when the server instantiates the component?
That's the question.

@ZheSun88 ZheSun88 assigned ZheSun88 and unassigned ZheSun88 Jan 26, 2018
@denis-anisimov denis-anisimov self-assigned this Jan 29, 2018
@denis-anisimov
Copy link
Contributor

I know the reason. Let it be assigned to me to avoid wasting time from someone who doesn't familiar with the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants