-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect client side "hidden" attribute handling setVisible functionality #3438
Conversation
a9d673b
to
65f19e4
Compare
Reviewed 8 of 9 files at r1, 1 of 1 files at r2. flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/HiddenTemplateView.java, line 45 at r2 (raw file):
New line here Comments from Reviewable |
Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion. flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/HiddenTemplateView.java, line 45 at r2 (raw file): Previously, gilberto-torrezan (Gilberto Torrezan) wrote…
Done. Comments from Reviewable |
Reviewed 1 of 1 files at r3. Comments from Reviewable |
SonarQube analysis reported 2 issues Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:
|
Fix for #3334
This change is