Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect client side "hidden" attribute handling setVisible functionality #3438

Merged
merged 8 commits into from
Jan 31, 2018

Conversation

denis-anisimov
Copy link
Contributor

@denis-anisimov denis-anisimov commented Jan 30, 2018

Fix for #3334


This change is Reviewable

@gilberto-torrezan
Copy link
Contributor

Reviewed 8 of 9 files at r1, 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/HiddenTemplateView.java, line 45 at r2 (raw file):

    }

}

New line here


Comments from Reviewable

@denis-anisimov
Copy link
Contributor Author

Review status: 8 of 9 files reviewed at latest revision, 1 unresolved discussion.


flow-tests/test-root-context/src/main/java/com/vaadin/flow/uitest/ui/template/HiddenTemplateView.java, line 45 at r2 (raw file):

Previously, gilberto-torrezan (Gilberto Torrezan) wrote…

New line here

Done.


Comments from Reviewable

@gilberto-torrezan
Copy link
Contributor

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 2 issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. MAJOR SimpleElementBindingStrategy.java#: This file has 817 lines, which is greater than 750 authorized. Split it into smaller files. rule
  2. MAJOR SimpleElementBindingStrategy.java#L737: Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. rule

@denis-anisimov denis-anisimov merged commit 9bdaa88 into master Jan 31, 2018
@denis-anisimov denis-anisimov deleted the 3334-hidden branch January 31, 2018 07:57
@ZheSun88 ZheSun88 added this to the 1.0.0.alpha19 milestone Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants