Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove read-only flag on copy #12715

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Conversation

caalador
Copy link
Contributor

When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711

@github-actions
Copy link

github-actions bot commented Jan 13, 2022

Unit Test Results

   770 files     770 suites   25m 14s ⏱️
5 744 tests 5 692 ✔️ 52 💤 0
5 779 runs  5 726 ✔️ 53 💤 0

Results for commit 7440410.

♻️ This comment has been updated with latest results.

When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
@caalador caalador force-pushed the issues/12711_read_only_on_copy branch from bc466b4 to 7440410 Compare January 14, 2022 11:19
@sonarcloud
Copy link

sonarcloud bot commented Jan 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vaadin-bot vaadin-bot added +1.0.0 and removed +0.0.1 labels Jan 14, 2022
@caalador caalador added +0.0.1 and removed +1.0.0 labels Jan 14, 2022
@caalador caalador requested a review from anssit January 14, 2022 12:52
@caalador caalador merged commit 69aa0df into master Jan 17, 2022
@caalador caalador deleted the issues/12711_read_only_on_copy branch January 17, 2022 08:07
vaadin-bot pushed a commit that referenced this pull request Jan 17, 2022
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
vaadin-bot pushed a commit that referenced this pull request Jan 17, 2022
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
vaadin-bot pushed a commit that referenced this pull request Jan 17, 2022
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
vaadin-bot added a commit that referenced this pull request Jan 17, 2022
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jan 17, 2022
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this pull request Jan 17, 2022
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha3 and is also targeting the upcoming stable 23.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Frontend file copy should NOT copy the readonly bit
3 participants