Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend file copy should NOT copy the readonly bit #12711

Closed
kklein-celera opened this issue Jan 12, 2022 · 3 comments · Fixed by #12715
Closed

Frontend file copy should NOT copy the readonly bit #12711

kklein-celera opened this issue Jan 12, 2022 · 3 comments · Fixed by #12715
Assignees
@caalador
Labels
bug Impact: Low prerelease version for platform 23.0.0 Released with Platform 14.8.3 Released with Platform 22.0.4 Released with Platform 23.0.0.alpha3 Severity: Minor

Comments

@kklein-celera
Copy link

kklein-celera commented Jan 12, 2022 •
edited
Loading

Description of the bug

When copying files from the application's frontend resource directory, the readonly status of the copied files should NOT also be copied. Otherwise, you gets lots of these errors the next time the frontend is copied:

java.lang.IllegalArgumentException: File parameter 'destFile is not writable:

The files in my application's src/main/resources/META-INF/frontend folder are read-only because they are managed by source control.

Expected behavior

All files copied into the target/flow-frontend folder should be writable, regardless of the writable status in the source folder or jar.

Minimal reproducible example

  1. Create a CSS file in src/main/resources/META-INF/frontend and mark it as read-only using your underlying OS tools.
  2. Run the application using "jetty run"
  3. Notice that the CSS file copied to target/flow-frontend is also read-only.

Versions

  • Vaadin / Flow version: 22.0.2
  • Java version: 11.0.2
  • OS version: Windows 10
  • Browser version (if applicable): N/A
  • Application Server (if applicable): N/A
  • IDE (if applicable): N/A
caalador added a commit that referenced this issue Jan 13, 2022
@caalador
fix: Remove read-only flag on copy
49aec72 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
@caalador caalador mentioned this issue Jan 13, 2022
Merged
@caalador caalador self-assigned this Jan 13, 2022
caalador added a commit that referenced this issue Jan 13, 2022
@caalador
fix: Remove read-only flag on copy
2ec28ec 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
caalador added a commit that referenced this issue Jan 14, 2022
@caalador
fix: Remove read-only flag on copy
dcaebcd 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
caalador added a commit that referenced this issue Jan 17, 2022
@caalador
fix: Remove read-only flag on copy (#12715)
69aa0df 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
vaadin-bot pushed a commit that referenced this issue Jan 17, 2022
@caalador @vaadin-bot
fix: Remove read-only flag on copy (#12715)
e5281b6 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
vaadin-bot pushed a commit that referenced this issue Jan 17, 2022
@caalador @vaadin-bot
fix: Remove read-only flag on copy (#12715)
1c36d7c 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
vaadin-bot pushed a commit that referenced this issue Jan 17, 2022
@caalador @vaadin-bot
fix: Remove read-only flag on copy (#12715)
bbbc96d 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711
vaadin-bot added a commit that referenced this issue Jan 17, 2022
@vaadin-bot @caalador
fix: Remove read-only flag on copy (#12715) (#12737)
0ad86da 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this issue Jan 17, 2022
@vaadin-bot @caalador
fix: Remove read-only flag on copy (#12715) (#12735)
41e5f87 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
vaadin-bot added a commit that referenced this issue Jan 17, 2022
@vaadin-bot @caalador
fix: Remove read-only flag on copy (#12715) (#12736)
ce710a9 
When copying the local frontend files
remove any read-only flags from the
copies.

fixes #12711

Co-authored-by: caalador <mikael.grankvist@vaadin.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 23.0.0.alpha3 and is also targeting the upcoming stable 23.0.0 version.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 22.0.4.

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with platform 14.8.3.

@thomasharre thomasharre mentioned this issue Sep 2, 2024
Closed
@mcollovati mcollovati mentioned this issue Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
bug Impact: Low prerelease version for platform 23.0.0 Released with Platform 14.8.3 Released with Platform 22.0.4 Released with Platform 23.0.0.alpha3 Severity: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove read-only flag on copy vaadin/flow
3 participants
@caalador @vaadin-bot @kklein-celera