Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add option to not modify readonly files during copy, add logging of time (#19894) (CP: 24.4) #19906

Merged
merged 1 commit into from
Sep 6, 2024
Merged

feat: Add option to not modify readonly files during copy, add logging of time (#19894) (CP: 24.4) #19906

merged 1 commit into from
Sep 6, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@TatuLund @vaadin-bot
feat: Add option to not modify readonly files during copy, add loggin…
2856fd6 
…g of time (#19894)

Allows to skip setting writable flag on copied files by providing the vaadin.frontend.disableWritableFlagCheckOnCopy system property.
This may improve performance in certain scenarios with Windows OS.

Fixes #19866
@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot vaadin-bot enabled auto-merge (squash) September 6, 2024 09:33
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 6, 2024

Test Results

1 109 files  ± 0  1 109 suites  ±0   1h 23m 31s ⏱️ +9s
7 052 tests ± 0  7 003 ✅ ± 0  49 💤 ±0  0 ❌ ±0 
7 419 runs  +26  7 358 ✅ +26  61 💤 ±0  0 ❌ ±0 

Results for commit 2856fd6. ± Comparison against base commit a4bf952.

@vaadin-bot vaadin-bot merged commit 37a773b into 24.4 Sep 6, 2024
25 of 26 checks passed
@vaadin-bot vaadin-bot deleted the cherry-pick-19894-to-24.4-1725614806606 branch September 6, 2024 09:42
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with Vaadin 24.4.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
Released with Vaadin 24.4.12 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaadin-bot @vaadin-review-bot @TatuLund